Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

formats prefix to not be flowrun every time #400

Merged
merged 8 commits into from
Apr 3, 2024

Conversation

jeanluciano
Copy link
Contributor

@jeanluciano jeanluciano commented Mar 22, 2024

Closes #402

Example

Checklist

  • [ x ] References any related issue by including "Closes #" or "Closes ".
    • If no issue exists and your change is not a small fix, please create an issue first.
  • [ x ] Includes tests or only affects documentation.
  • [ x ] Passes pre-commit checks.
    • Run pre-commit install && pre-commit run --all locally for formatting and linting.
  • Includes screenshots of documentation updates.
    • Run mkdocs serve view documentation locally.

@jeanluciano jeanluciano marked this pull request as ready for review March 28, 2024 14:07
@jeanluciano jeanluciano requested a review from a team as a code owner March 28, 2024 14:07
@jeanluciano jeanluciano self-assigned this Mar 28, 2024
@kevingrismore
Copy link
Contributor

Am I right in understanding that the logs prefix setting can still be overridden by including it explicitly in cloudwatch_logs_options?

@jeanluciano
Copy link
Contributor Author

Am I right in understanding that the logs prefix setting can still be overridden by including it explicitly in cloudwatch_logs_options?

Yeah users can still set it if they'd like too.

Copy link
Contributor

@kevingrismore kevingrismore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just so it's clear to users what happens if both are set.

prefect_aws/workers/ecs_worker.py Outdated Show resolved Hide resolved
@@ -1245,6 +1245,7 @@ async def test_cloudwatch_log_options(aws_credentials):
if container["name"] == "prefect":
# Assert that the 'prefect' container has logging configured with user
# provided options
print(container["logConfiguration"])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
print(container["logConfiguration"])

@jeanluciano jeanluciano merged commit e6b15c2 into main Apr 3, 2024
7 checks passed
@jeanluciano jeanluciano deleted the awslogs-stream-prefix-update branch April 3, 2024 20:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change logging prefix to avoid unnecessary task definition registrations
3 participants