Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

fix client hashing in nested client params case #373

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

zzstoatzz
Copy link
Contributor

@zzstoatzz zzstoatzz commented Jan 24, 2024

This PR fixes a bug when the config object in AwsClientParameters is not hashable (which is normally, since its a dict)

Closes #372

Example

Screenshots

Checklist

  • References any related issue by including "Closes #" or "Closes ".
    • If no issue exists and your change is not a small fix, please create an issue first.
  • Includes tests or only affects documentation.
  • Passes pre-commit checks.
    • Run pre-commit install && pre-commit run --all locally for formatting and linting.
  • Includes screenshots of documentation updates.
    • Run mkdocs serve view documentation locally.
  • Summarizes PR's changes in CHANGELOG.md

@zzstoatzz zzstoatzz requested a review from a team as a code owner January 24, 2024 18:10
@zzstoatzz zzstoatzz self-assigned this Jan 24, 2024
@zzstoatzz zzstoatzz merged commit 04b9000 into main Jan 24, 2024
6 checks passed
@zzstoatzz zzstoatzz deleted the hotfix/client-hashing branch January 24, 2024 18:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in version 0.4.8: TypeError: unhashable type: 'dict'
2 participants