Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Read AWS Secrets with 'SecretString' #274

Merged
merged 7 commits into from
Nov 13, 2023
Merged

Conversation

nick-amplify
Copy link
Contributor

@nick-amplify nick-amplify commented Jun 7, 2023

Closes #265

Example

Screenshots

Checklist

  • References any related issue by including "Closes #" or "Closes ".
    • If no issue exists and your change is not a small fix, please create an issue first.
  • Includes tests or only affects documentation.
  • Passes pre-commit checks.
    • Run pre-commit install && pre-commit run --all locally for formatting and linting.
  • Summarizes PR's changes in CHANGELOG.md

@nick-amplify nick-amplify requested a review from a team June 7, 2023 17:19
Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing @nick-amplify! Could you please add some tests covering this new functionality?

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Alexander Streed <[email protected]>
@desertaxle
Copy link
Member

@nick-amplify just checking to see if you can write some tests for this PR 🙂

@desertaxle desertaxle requested a review from a team as a code owner September 28, 2023 15:15
@desertaxle desertaxle self-assigned this Oct 17, 2023
@Bryan-Meier
Copy link

I'm curious if this PR will make it into the main branch any time soon? We are wanting to leverage the SecretString functionality as all of our Secrets are in SecretString format and not SecretBinary. Thanks in advance!

@desertaxle desertaxle merged commit 679fad1 into PrefectHQ:main Nov 13, 2023
6 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reading AWS Secret 'SecretString'
4 participants