Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Anime Sama): add privacy mode && feat(Voiranime) : add multilanguage, privacy mode and show buttons settings #8837

Closed
wants to merge 5 commits into from

Conversation

skullysmods
Copy link
Contributor

@skullysmods skullysmods commented Oct 25, 2024

Description

Add privacy mode to Anime Sama Presence

Acknowledgements

Screenshots

Proof showing the creation/modification is working as expected

With privacy mode off:
image

With privacy mode on :
image

@skullysmods skullysmods marked this pull request as draft October 25, 2024 15:32
@skullysmods skullysmods changed the title feat(Anime Sama): add privacy mode feat(Anime Sama): add privacy mode && feat(Voiranime) : add multilanguage, privacy mode and show buttons settings Oct 25, 2024
@skullysmods skullysmods marked this pull request as ready for review October 25, 2024 19:31
Copy link
Member

@theusaf theusaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you split this into two separate PRs?

@skullysmods
Copy link
Contributor Author

skullysmods commented Oct 25, 2024

Okay, I'll do that :)
I'm closing this PR in the meantime

@skullysmods
Copy link
Contributor Author

It's good ^^
The first one : #8839
The second one : #8840

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants