Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added contributors to the readme.md file #36

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

added contributors to the readme.md file #36

wants to merge 4 commits into from

Conversation

Himanshi1207
Copy link

No description provided.

PrajaktaSathe
PrajaktaSathe reviewed Oct 23, 2021
View reviewed changes
Copy link
Owner

@PrajaktaSathe PrajaktaSathe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Could you check if these names can appear as icons (with their profile pictures)?

@PrajaktaSathe
Copy link
Owner

Looks good! 👍🏻
But would this have to be manually updated by every contributor? 😅

@Himanshi1207
Copy link
Author

Yes this has to be updated manually :')
I tried to search for the way in which it automatically gets updated.
Actually we have to add the image link to the readme.md file otherwise the photo of the contributor will not be visible.

@PrajaktaSathe
Copy link
Owner

Check this! See if you can implement it in a similar way. 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PrajaktaSathe PrajaktaSathe PrajaktaSathe left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Himanshi1207 @PrajaktaSathe