Adding tests to cDscResourceDesigner #100
Conversation
…tests Conflicts: Tooling/cDscResourceDesigner/cDscResourceDesigner.psm1
…to development-tests
|
Why is git showing differences on lines that appear to be identical in this PR? It makes it very hard to evaluate... did you change spaces to tabs or vice versa, file encoding, or something? Edit: According to Winmerge, it's the line endings. Looks like we've somehow got a file with Unix line endings in the development branch instead of Windows. I'll fix that, and then your PR should be easier to evaluate. |
| Describe Test-cDscResource { | ||
| Context 'A module with a psm1 file but no matching schema.mof' { | ||
| Setup -Dir TestResource | ||
| Setup -File TestResource\TestResource.ps1m -Content (Get-TestDscResourceModuleContent) |
There was a problem hiding this comment.
I assume "ps1m" is a typo here, supposed to be psm1?
There was a problem hiding this comment.
Let's assume so. 😄 Fixed it either way.
|
I haven't had time for a very thorough review of all these new tests, but most of them are passing, which is a good sign. :) (There was one exception; I added a line comment for that.) |
|
Glad most of them are passing! 😆 Made some adjustments you commented on, hopefully I'll have more time this week to review it myself with fresh eyes and catch anything that I may have missed. |
…to development-tests Conflicts: Tooling/cDscResourceDesigner/cDscResourceDesigner.Tests.ps1 Tooling/cDscResourceDesigner/cDscResourceDesigner.psm1
|
Your latest commit (merging the development branch into your PR) seems to have wiped out all of your new tests. You should probably revert to d107c61 |
|
Sorry about taking so long to get to this. It's rolled back now. |
| @@ -35,6 +35,786 @@ end | |||
| } | |||
| } | |||
| } | |||
| <<<<<<< HEAD | |||
There was a problem hiding this comment.
Got some merge conflict leftovers to take care of here :)
This was forked against the development branch because I wanted to incorporate some of the changes that we're being made. This is ~60% code coverage, so still pretty far from my goal of 80% but I was beginning to question some of my testing methods so I figured it would be best to put it in front of some people while I continued to add and refactor. Suggestions welcome!