Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix how we retrieve the installation id form AzCLI and AzPSH profile #260

Merged
merged 7 commits into from
Oct 31, 2024
Merged

Fix how we retrieve the installation id form AzCLI and AzPSH profile #260

merged 7 commits into from
Oct 31, 2024

Conversation

NoriZC
Copy link
Contributor

@NoriZC NoriZC commented Oct 30, 2024 •
edited
Loading

PR Summary

  • Updated Installation Id Initialization to support both AzPS and AzCLI on Unbuntu. Tested on both ubuntu dockers for azps and azcli.

    • AzCLI:

    • image

    • AzPSH:

    • image

PR Context

@daxian-dbw
Copy link
Member

@NoriZC Please revert the changes in AzureAgent.cs. We will put off telemetry code changes until the metrics for each telemetry are well defined.

@NoriZC NoriZC changed the title Update Installation Id Initialization to support both AzPS and AzCLI on Unbuntu Update the telemetry for azms Oct 30, 2024
@NoriZC NoriZC changed the title Update the telemetry for azms Update the telemetry for msaz Oct 30, 2024
@NoriZC
Copy link
Contributor Author

NoriZC commented Oct 30, 2024

@NoriZC Please revert the changes in AzureAgent.cs. We will put off telemetry code changes until the metrics for each telemetry are well defined.

OK, I will seperate this PR soon

@daxian-dbw
Copy link
Member

daxian-dbw commented Oct 30, 2024 •
edited
Loading

OK, I will seperate this PR soon

Do not work on the new changes yet. We need the metrics to be well defined before start coding work. We don't want to make changes again and again.

@daxian-dbw
Copy link
Member

@NoriZC You can continue with fixing installation id in this PR, but please revert the unrelated changes.

@daxian-dbw daxian-dbw merged commit 36afb32 into PowerShell:main Oct 31, 2024
4 checks passed
@daxian-dbw daxian-dbw changed the title Update the telemetry for msaz Fix how we retrieve the installation id form AzCLI and AzPSH profile Oct 31, 2024
@NoriZC NoriZC deleted the telemetry-update branch October 31, 2024 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daxian-dbw daxian-dbw daxian-dbw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NoriZC @daxian-dbw