This repository has been archived by the owner on Jun 14, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 53
[WIP] Fix Sample Files that are failing Validation Tests #148
Open
X-Guardian
wants to merge
31
commits into
PowerShell:dev
Choose a base branch
from
X-Guardian:Example-Fix
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #148 +/- ##
===================================
- Coverage 83% 80% -3%
===================================
Files 19 19
Lines 2760 2760
Branches 4 4
===================================
- Hits 2303 2234 -69
- Misses 453 522 +69
Partials 4 4 |
- Rename PasswordCredential for opt-in tests - Add Mandatory parameter and ValidateNotNullorEmpty - Add Node localhost - Fix formatting
- Remove configuration call - Fix formatting - Add Node localhost
- Add ValidateNotNullOrEmpty to mandatory parameters - Add Node localhost - Remove configuration call - Fix formatting - Rename incorrect resource name
* Test-Is NanoServer speed improvement Replace Get-ComputerInfo with Registry Value Test * update README.md * Add check for ServerLevels Reg Key for Non-Server * Update CommonResourceHelper.Tests * Moved comment to unreleased * Make requested changes * Remove whitespace * README.md markdownlint fixes * README markdownlint fix * README branch detail format change To match other DSC modules * Update README * Fix Example dir BOM files * Fix Tests\Integration dir BOM files * Fix Tests\Unit dir BOM files * Fix PSDscResources dir BOM files * Fix Tests\TestHelpers dir BOM files * Add Script & Module Common Tests to MetaTestOptIn * Update README * Revert "Fix msi package tests" * Fix MsiPackage tests... for real this time * Fix MsiPackage tests... for real this time * Fix MsiPackage tests... for real this time - Post Review #1 * Fix MsiPackage tests... for real this time - Post Review #1 * Update CommonResourceHelper.psm1 * Update README * Update README.md * Update README.md
- Rename PasswordCredential for opt-in tests - Add Mandatory parameter and ValidateNotNullorEmpty - Add Node localhost - Fix formatting
- Remove configuration call - Fix formatting - Add Node localhost
- Add ValidateNotNullOrEmpty to mandatory parameters - Add Node localhost - Remove configuration call - Fix formatting - Rename incorrect resource name
…urces into Example-Fix # Conflicts: # Examples/Sample_User_Generic.ps1
Hi @mhendric, I can't get this PR to pass its Appveyor build. Its failing with the following error:
I tried putting some code in to remove the module before loading it, but it made no difference. The test runs fine locally. Any ideas? |
Hey @X-Guardian , can you try completely reverting the changes that were made in ResourceSetHelper.Tests.ps1 and see if it makes a difference? The state of the code as is definitely looks odd to me with the new commented out code. Want to see if it fails even if no changes are made. Thanks. |
PlagueHO
added
the
waiting for code fix
A review left open comments, and the pull request is waiting for changes to be pushed by the author.
label
Oct 4, 2019
Still failing the Appveyor tests with the same error:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
waiting for code fix
A review left open comments, and the pull request is waiting for changes to be pushed by the author.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This PR fixes the sample files that are failing the
Common Tests - Validate Example Files
opt-in meta-testThis Pull Request (PR) fixes the following issues
None
Task list
Entry should say what was changed, and how that affects users (if applicable).
and comment-based help.
This change is