Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Improve eslint setup #109

Merged
merged 1 commit into from
Aug 31, 2023
Merged

style: Improve eslint setup #109

merged 1 commit into from
Aug 31, 2023

Conversation

robbie-c
Copy link
Contributor

@robbie-c robbie-c commented Aug 27, 2023

Problem

Just code style

Changes

Added eslint-plugin-react-hooks, eslint-plugin-jest, and eslint:recommended.

Then manually went through and fixed anything that needed fixing. I spent a bit of time thinking through the react hooks changes, to convince myself that they were correct/beneficial, and a reviewer probably would want to do the same.

Release info Sub-libraries affected

Bump level

  • Major
  • Minor
  • Patch

Libraries affected

  • All of them
  • posthog-web
  • posthog-node
  • posthog-react-native

Changelog notes

  • Added eslint plugins (eslint-plugin-react-hooks and eslint-plugin-jest) and config (eslint:recommended)

Copy link
Contributor

@neilkakkar neilkakkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the posthog provider changes, was this prompted by some eslint rule?

But otherwise LGTM!

@robbie-c
Copy link
Contributor Author

Yeah, it comes from eslint-plugin-react-hooks, a plugin made by the react team (https://www.npmjs.com/package/eslint-plugin-react-hooks)

@robbie-c robbie-c merged commit 7ad76f9 into master Aug 31, 2023
2 checks passed
@robbie-c robbie-c deleted the improve-eslint-setup branch August 31, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants