fix: clear flagCallReported if there are new flags (#281)

PostHog · Oct 11, 2024 · 95fe45d · 95fe45d
1 parent ca271b8
commit 95fe45d
Show file tree

Hide file tree

Showing 5 changed files with 56 additions and 2 deletions.
diff --git a/posthog-core/src/index.ts b/posthog-core/src/index.ts
@@ -761,6 +761,7 @@ export abstract class PostHogCore extends PostHogCoreStateless {
   private clearProps(): void {
     this.props = undefined
     this.sessionProps = {}
+    this.flagCallReported = {}
   }
 
   private _props: PostHogEventProperties | undefined
@@ -1109,6 +1110,11 @@ export abstract class PostHogCore extends PostHogCoreStateless {
 
         return super.getDecide(distinctId, groups, personProperties, groupProperties, extraProperties).then((res) => {
           if (res?.featureFlags) {
+            // clear flag call reported if we have new flags since they might have changed
+            if (this.sendFeatureFlagEvent) {
+              this.flagCallReported = {}
+            }
+
             let newFeatureFlags = res.featureFlags
             let newFeatureFlagPayloads = res.featureFlagPayloads
             if (res.errorsWhileComputingFlags) {

diff --git a/posthog-core/test/posthog.featureflags.spec.ts b/posthog-core/test/posthog.featureflags.spec.ts
@@ -418,6 +418,48 @@ describe('PostHog Core', () => {
         expect(mocks.fetch).toHaveBeenCalledTimes(2)
       })
 
+      it('should capture $feature_flag_called again if new flags', async () => {
+        expect(posthog.getFeatureFlag('feature-1')).toEqual(true)
+        await waitForPromises()
+        expect(mocks.fetch).toHaveBeenCalledTimes(2)
+
+        expect(parseBody(mocks.fetch.mock.calls[1])).toMatchObject({
+          batch: [
+            {
+              event: '$feature_flag_called',
+              distinct_id: posthog.getDistinctId(),
+              properties: {
+                $feature_flag: 'feature-1',
+                $feature_flag_response: true,
+                '$feature/feature-1': true,
+              },
+              type: 'capture',
+            },
+          ],
+        })
+
+        await posthog.reloadFeatureFlagsAsync()
+        posthog.getFeatureFlag('feature-1')
+
+        await waitForPromises()
+        expect(mocks.fetch).toHaveBeenCalledTimes(4)
+
+        expect(parseBody(mocks.fetch.mock.calls[3])).toMatchObject({
+          batch: [
+            {
+              event: '$feature_flag_called',
+              distinct_id: posthog.getDistinctId(),
+              properties: {
+                $feature_flag: 'feature-1',
+                $feature_flag_response: true,
+                '$feature/feature-1': true,
+              },
+              type: 'capture',
+            },
+          ],
+        })
+      })
+
       it('should persist feature flags', () => {
         expect(posthog.getPersistedProperty(PostHogPersistedProperty.FeatureFlags)).toEqual(createMockFeatureFlags())
       })

diff --git a/posthog-react-native/CHANGELOG.md b/posthog-react-native/CHANGELOG.md
@@ -1,5 +1,11 @@
 # Next
 
+# 3.3.2 - 2024-10-11
+
+## Changed
+
+1. fix: clear flagCallReported if there are new flags
+
 # 3.3.1 - 2024-09-30
 
 ## Changed

diff --git a/posthog-react-native/package.json b/posthog-react-native/package.json
@@ -1,6 +1,6 @@
 {
   "name": "posthog-react-native",
-  "version": "3.3.1",
+  "version": "3.3.2",
   "main": "lib/posthog-react-native/index.js",
   "files": [
     "lib/"

diff --git a/posthog-react-native/src/optional/OptionalSessionReplay.ts b/posthog-react-native/src/optional/OptionalSessionReplay.ts
@@ -10,4 +10,4 @@ try {
     web: undefined,
     default: require('posthog-react-native-session-replay'), // Only Android and iOS
   })
-} catch (e) { }
+} catch (e) {}