fix(flags): Make sure to add feature props to ffc events (#103)

* fix(flags): Make sure to add feature props to ffc events * add to core
PostHog · Aug 17, 2023 · 54178fc · 54178fc
1 parent b70f194
commit 54178fc
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 1 deletion.
diff --git a/posthog-core/test/posthog.featureflags.spec.ts b/posthog-core/test/posthog.featureflags.spec.ts
@@ -400,6 +400,7 @@ describe('PostHog Core', () => {
               properties: {
                 $feature_flag: 'feature-1',
                 $feature_flag_response: true,
+                '$feature/feature-1': true,
               },
               type: 'capture',
             },

diff --git a/posthog-node/CHANGELOG.md b/posthog-node/CHANGELOG.md
@@ -1,3 +1,7 @@
+# 3.1.2 - 2023-08-17
+
+1. Returns the current flag property with $feature_flag_called events, to make it easier to use in experiments
+
 # 3.1.1 - 2023-04-26
 
 1. Replace crypto library with pure-js rusha library which makes posthog-node work with Cloudflare Workers in Next.js edge runtime.

diff --git a/posthog-node/package.json b/posthog-node/package.json
@@ -1,6 +1,6 @@
 {
   "name": "posthog-node",
-  "version": "3.1.1",
+  "version": "3.1.2",
   "description": "PostHog Node.js integration",
   "repository": "PostHog/posthog-node",
   "scripts": {

diff --git a/posthog-node/src/posthog-node.ts b/posthog-node/src/posthog-node.ts
@@ -207,6 +207,7 @@ export class PostHog extends PostHogCoreStateless implements PostHogNodeV1 {
           $feature_flag: key,
           $feature_flag_response: response,
           locally_evaluated: flagWasLocallyEvaluated,
+          [`$feature/${key}`]: response,
         },
         groups,
         disableGeoip,

diff --git a/posthog-node/test/posthog-node.spec.ts b/posthog-node/test/posthog-node.spec.ts
@@ -555,6 +555,7 @@ describe('PostHog Node.js', () => {
               $lib: 'posthog-node',
               $lib_version: '1.2.3',
               locally_evaluated: true,
+              '$feature/beta-feature': true,
             }),
           },
         ])
@@ -610,6 +611,7 @@ describe('PostHog Node.js', () => {
           properties: expect.objectContaining({
             $feature_flag: 'beta-feature',
             $feature_flag_response: true,
+            '$feature/beta-feature': true,
             $lib: 'posthog-node',
             $lib_version: '1.2.3',
             locally_evaluated: true,
@@ -652,6 +654,7 @@ describe('PostHog Node.js', () => {
         $lib: 'posthog-node',
         $lib_version: '1.2.3',
         locally_evaluated: true,
+        '$feature/beta-feature': true,
         $groups: { x: 'y' },
       })
       mockedFetch.mockClear()
@@ -688,6 +691,7 @@ describe('PostHog Node.js', () => {
             $lib: 'posthog-node',
             $lib_version: '1.2.3',
             locally_evaluated: false,
+            '$feature/decide-flag': 'decide-value',
             $groups: { organization: 'org1' },
           }),
         })