Merge pull request #118 from Portkey-AI/feat/update-feedback

update feedback

portkey_ai/api_resources/apis/api_resource.py

@@ -19,6 +19,9 @@ def __init__(self, client: APIClient) -> None:
     def _post(self, *args, **kwargs):
         return self._client._post(*args, **kwargs)
 
+    def _put(self, *args, **kwargs):
+        return self._client._put(*args, **kwargs)
+
 
 class AsyncAPIResource:
     _client: AsyncAPIClient
@@ -32,6 +35,9 @@ def __init__(self, client: AsyncAPIClient) -> None:
 
     async def _post(self, *args, **kwargs):
         return await self._client._post(*args, **kwargs)
+
+    async def _put(self, *args, **kwargs):
+        return await self._client._put(*args, **kwargs)
 
     async def _sleep(self, seconds: float) -> None:
         await asyncio.sleep(seconds)

portkey_ai/api_resources/apis/feedback.py

@@ -2,7 +2,8 @@
 from portkey_ai.api_resources.apis.api_resource import APIResource, AsyncAPIResource
 from portkey_ai.api_resources.base_client import APIClient, AsyncAPIClient
 from portkey_ai.api_resources.streaming import AsyncStream, Stream
-from portkey_ai.api_resources.utils import GenericResponse, PortkeyApiPaths
+from portkey_ai.api_resources.types.feedback_type import FeedbackResponse
+from portkey_ai.api_resources.utils import PortkeyApiPaths
 
 
 class Feedback(APIResource):
@@ -16,26 +17,46 @@ def create(
         value: Optional[int] = None,
         weight: Optional[float] = None,
         metadata: Optional[Dict[str, Any]] = None
-    ) -> GenericResponse:
+    ) -> FeedbackResponse:
         body = dict(trace_id=trace_id, value=value, weight=weight, metadata=metadata)
         return self._post(
             PortkeyApiPaths.FEEDBACK_API,
             body=body,
             params=None,
-            cast_to=GenericResponse,
-            stream_cls=Stream[GenericResponse],
+            cast_to=FeedbackResponse,
+            stream_cls=Stream[FeedbackResponse],
             stream=False,
             headers={},
         )
 
-    def bulk_create(self, *, feedbacks: List[Dict[str, Any]]) -> GenericResponse:
+    def bulk_create(self, *, feedbacks: List[Dict[str, Any]]) -> FeedbackResponse:
         body = feedbacks
         return self._post(
             PortkeyApiPaths.FEEDBACK_API,
             body=body,
             params=None,
-            cast_to=GenericResponse,
-            stream_cls=Stream[GenericResponse],
+            cast_to=FeedbackResponse,
+            stream_cls=Stream[FeedbackResponse],
+            stream=False,
+            headers={},
+        )
+
+    def update(
+        self,
+        *,
+        feedback_id: Optional[str] = None,
+        value: Optional[int] = None,
+        weight: Optional[float] = None,
+        metadata: Optional[Dict[str, Any]] = None
+    ) -> FeedbackResponse:
+        body = dict(value=value, weight=weight, metadata=metadata)
+
+        return self._put(
+            f"{PortkeyApiPaths.FEEDBACK_API}/{feedback_id}",
+            body=body,
+            params=None,
+            cast_to=FeedbackResponse,
+            stream_cls=Stream[FeedbackResponse],
             stream=False,
             headers={},
         )
@@ -52,26 +73,45 @@ async def create(
         value: Optional[int] = None,
         weight: Optional[float] = None,
         metadata: Optional[Dict[str, Any]] = None
-    ) -> GenericResponse:
+    ) -> FeedbackResponse:
         body = dict(trace_id=trace_id, value=value, weight=weight, metadata=metadata)
         return await self._post(
             PortkeyApiPaths.FEEDBACK_API,
             body=body,
             params=None,
-            cast_to=GenericResponse,
-            stream_cls=AsyncStream[GenericResponse],
+            cast_to=FeedbackResponse,
+            stream_cls=AsyncStream[FeedbackResponse],
             stream=False,
             headers={},
         )
 
-    async def bulk_create(self, *, feedbacks: List[Dict[str, Any]]) -> GenericResponse:
+    async def bulk_create(self, *, feedbacks: List[Dict[str, Any]]) -> FeedbackResponse:
         body = feedbacks
         return await self._post(
             PortkeyApiPaths.FEEDBACK_API,
             body=body,
             params=None,
-            cast_to=GenericResponse,
-            stream_cls=AsyncStream[GenericResponse],
+            cast_to=FeedbackResponse,
+            stream_cls=AsyncStream[FeedbackResponse],
+            stream=False,
+            headers={},
+        )
+
+    async def update(
+        self,
+        *,
+        feedback_id: Optional[str] = None,
+        value: Optional[int] = None,
+        weight: Optional[float] = None,
+        metadata: Optional[Dict[str, Any]] = None
+    ) -> FeedbackResponse:
+        body = dict(value=value, weight=weight, metadata=metadata)
+        return await self._put(
+            f"{PortkeyApiPaths.FEEDBACK_API}/{feedback_id}",
+            body=body,
+            params=None,
+            cast_to=FeedbackResponse,
+            stream_cls=Stream[FeedbackResponse],
             stream=False,
             headers={},
         )

portkey_ai/api_resources/base_client.py

@@ -181,6 +181,76 @@ def _post(
         )
         return res
 
+    @overload
+    def _put(
+        self,
+        path: str,
+        *,
+        body: Mapping[str, Any],
+        cast_to: Type[ResponseT],
+        stream: Literal[True],
+        stream_cls: type[StreamT],
+        params: Mapping[str, str],
+        headers: Mapping[str, str],
+    ) -> StreamT:
+        ...
+
+    @overload
+    def _put(
+        self,
+        path: str,
+        *,
+        body: Mapping[str, Any],
+        cast_to: Type[ResponseT],
+        stream: Literal[False],
+        stream_cls: type[StreamT],
+        params: Mapping[str, str],
+        headers: Mapping[str, str],
+    ) -> ResponseT:
+        ...
+
+    @overload
+    def _put(
+        self,
+        path: str,
+        *,
+        body: Mapping[str, Any],
+        cast_to: Type[ResponseT],
+        stream: bool,
+        stream_cls: type[StreamT],
+        params: Mapping[str, str],
+        headers: Mapping[str, str],
+    ) -> Union[ResponseT, StreamT]:
+        ...
+
+    def _put(
+        self,
+        path: str,
+        *,
+        body: Mapping[str, Any],
+        cast_to: Type[ResponseT],
+        stream: bool,
+        stream_cls: type[StreamT],
+        params: Mapping[str, str],
+        headers: Mapping[str, str],
+    ) -> Union[ResponseT, StreamT]:
+
+        opts = self._construct(
+            method="put",
+            url=path,
+            body=body,
+            stream=stream,
+            params=params,
+            headers=headers,
+        )
+        res = self._request(
+            options=opts,
+            stream=stream,
+            cast_to=cast_to,
+            stream_cls=stream_cls,
+        )
+        return res
+
     def _construct_generate_options(
         self,
         *,
@@ -530,6 +600,76 @@ async def _post(
         )
         return res
 
+    @overload
+    async def _put(
+        self,
+        path: str,
+        *,
+        cast_to: Type[ResponseT],
+        body: Mapping[str, Any],
+        stream: Literal[False],
+        stream_cls: type[AsyncStreamT],
+        params: Mapping[str, str],
+        headers: Mapping[str, str],
+    ) -> ResponseT:
+        ...
+
+    @overload
+    async def _put(
+        self,
+        path: str,
+        *,
+        cast_to: Type[ResponseT],
+        body: Mapping[str, Any],
+        stream: Literal[True],
+        stream_cls: type[AsyncStreamT],
+        params: Mapping[str, str],
+        headers: Mapping[str, str],
+    ) -> AsyncStreamT:
+        ...
+
+    @overload
+    async def _put(
+        self,
+        path: str,
+        *,
+        cast_to: Type[ResponseT],
+        body: Mapping[str, Any],
+        stream: bool,
+        stream_cls: type[AsyncStreamT],
+        params: Mapping[str, str],
+        headers: Mapping[str, str],
+    ) -> Union[ResponseT, AsyncStreamT]:
+        ...
+
+    async def _put(
+        self,
+        path: str,
+        *,
+        cast_to: Type[ResponseT],
+        body: Mapping[str, Any],
+        stream: bool,
+        stream_cls: type[AsyncStreamT],
+        params: Mapping[str, str],
+        headers: Mapping[str, str],
+    ) -> Union[ResponseT, AsyncStreamT]:
+
+        opts = await self._construct(
+            method="put",
+            url=path,
+            body=body,
+            stream=stream,
+            params=params,
+            headers=headers,
+        )
+        res = await self._request(
+            options=opts,
+            stream=stream,
+            cast_to=cast_to,
+            stream_cls=stream_cls,
+        )
+        return res
+
     async def _construct_generate_options(
         self,
         *,

portkey_ai/api_resources/client.py

@@ -16,6 +16,7 @@ class Portkey(APIClient):
     generations: apis.Generations
     prompts: apis.Prompts
     embeddings: apis.Embeddings
+    feedback: apis.Feedback
     images: apis.Images
     files: apis.MainFiles
     models: apis.Models
@@ -114,6 +115,7 @@ class AsyncPortkey(AsyncAPIClient):
     generations: apis.AsyncGenerations
     prompts: apis.AsyncPrompts
     embeddings: apis.AsyncEmbeddings
+    feedback: apis.AsyncFeedback
     images: apis.AsyncImages
     files: apis.AsyncMainFiles
     models: apis.AsyncModels

portkey_ai/api_resources/types/feedback_type.py

@@ -0,0 +1,12 @@
+import json
+from typing import Optional
+
+from .utils import parse_headers
+from typing import List
+from pydantic import BaseModel
+
+
+class FeedbackResponse(BaseModel):
+    status: Optional[str]
+    message: Optional[str]
+    feedback_ids: Optional[List[str]]

portkey_ai/api_resources/utils.py

@@ -15,6 +15,7 @@
     TextCompletionChunk,
     TextCompletion,
 )
+from portkey_ai.api_resources.types.feedback_type import FeedbackResponse
 from portkey_ai.api_resources.types.generation_type import (
     PromptCompletion,
     PromptCompletionChunk,
@@ -61,7 +62,7 @@ class CacheType(str, Enum, metaclass=MetaEnum):
 
 ResponseT = TypeVar(
     "ResponseT",
-    bound="Union[ChatCompletionChunk, ChatCompletions, TextCompletion, TextCompletionChunk, GenericResponse, PromptCompletion, PromptCompletionChunk, PromptRender,  httpx.Response]",  # noqa: E501
+    bound="Union[ChatCompletionChunk, ChatCompletions, TextCompletion, TextCompletionChunk, GenericResponse, PromptCompletion, PromptCompletionChunk, PromptRender, FeedbackResponse, httpx.Response]",  # noqa: E501
 )