Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(*): remove angular dependencies #60

Merged
merged 1 commit into from
Oct 10, 2024
Merged

chore(*): remove angular dependencies #60

merged 1 commit into from
Oct 10, 2024

Conversation

polymath-eric
Copy link
Collaborator

@polymath-eric polymath-eric commented Oct 10, 2024 •
edited
Loading

Description

angular packages aren't needed after ng-easy/builders removal

Previous error:

  npm ERR! code ERESOLVE
  npm ERR! ERESOLVE could not resolve
  npm ERR! 
  npm ERR! While resolving: @angular/[email protected]
  npm ERR! Found: @angular/[email protected]
  npm ERR! node_modules/@angular/compiler
  npm ERR!   dev @angular/compiler@"13.2.3" from the root project
  npm ERR!

https://github.com/PolymeshAssociation/signing-managers/actions/runs/11275782533/job/31358158904

Breaking Changes

JIRA Link

Checklist

  • Updated the Readme.md (if required) ?

@polymath-eric
chore(*): remove angular dependencies
20f8c11 
angular packages aren't needed after ng-easy/builders removal
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@polymath-eric
Copy link
Collaborator Author

/fast-forward

@prashantasdeveloper prashantasdeveloper merged commit 20f8c11 into alpha Oct 10, 2024
5 checks passed
@prashantasdeveloper prashantasdeveloper deleted the semantic-release branch October 10, 2024 14:47
@prashantasdeveloper
Copy link
Collaborator

🎉 This PR is included in version 3.4.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prashantasdeveloper prashantasdeveloper prashantasdeveloper approved these changes

@VictorVicente VictorVicente Awaiting requested review from VictorVicente VictorVicente is a code owner

@sansan sansan Awaiting requested review from sansan sansan is a code owner

Assignees
No one assigned
Labels
released on @alpha
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@polymath-eric @prashantasdeveloper