build(*): replace semantic release executor

replace @ng-easy/builders with @theunderscorer/nx-semantic-release. @ng-easy seems to have been removed from npm and github
PolymeshAssociation · Oct 7, 2024 · af9db9b · af9db9b
1 parent 02730cc
commit af9db9b
Show file tree

Hide file tree

Showing 16 changed files with 5,513 additions and 5,818 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -35,7 +35,7 @@ jobs:
       - name: install dependencies
         run: yarn --frozen-lockfile
       - name: build and release
-        run: yarn nx run-many --all --target=release --parallel=1
+        run: yarn nx run-many --all --target=version --parallel=false
         env:
           CI: true
           GITHUB_TOKEN: ${{ secrets.RELEASE_TOKEN }}

diff --git a/.gitignore b/.gitignore
@@ -39,4 +39,5 @@ testem.log
 Thumbs.db
 
 # Local testing
-packages/*/sandbox
+packages/*/sandbox
+.nx/
diff --git a/nx.json b/nx.json
@@ -1,15 +1,15 @@
 {
-  "extends": "@nrwl/workspace/presets/core.json",
+  "extends": "@nx/workspace/presets/core.json",
   "npmScope": "signing-managers",
   "affected": {
     "defaultBase": "main"
   },
   "cli": {
-    "defaultCollection": "@nrwl/workspace"
+    "defaultCollection": "@nx/workspace"
   },
   "tasksRunnerOptions": {
     "default": {
-      "runner": "@nrwl/workspace/tasks-runners/default",
+      "runner": "@nx/workspace/tasks-runners/default",
       "options": {
         "cacheableOperations": ["build", "lint", "test", "e2e"]
       }

diff --git a/package.json b/package.json
@@ -22,35 +22,33 @@
     "tslib": "^2.0.0"
   },
   "devDependencies": {
-    "@angular-devkit/build-angular": "13.2.3",
-    "@angular-devkit/core": "^13.2.3",
-    "@angular/compiler": "13.2.3",
-    "@angular/compiler-cli": "^13.0.0",
+    "@angular-devkit/build-angular": "^18.2.7",
+    "@angular-devkit/core": "^18.2.7",
+    "@angular-devkit/schematics": "^18.2.7",
+    "@angular/compiler": "^18.2.7",
+    "@angular/compiler-cli": "^18.2.7",
     "@babel/core": "^7.0.0",
     "@babel/plugin-transform-modules-commonjs": "^7.16.8",
     "@babel/plugin-transform-runtime": "^7.17.0",
     "@babel/polyfill": "^7.12.1",
     "@babel/preset-env": "^7.16.11",
-    "@commitlint/cli": "^16.2.1",
-    "@commitlint/config-conventional": "^16.2.1",
+    "@commitlint/cli": "^18.0.0",
+    "@commitlint/config-conventional": "^18.0.0",
     "@golevelup/ts-jest": "^0.5.6",
-    "@ng-easy/builders": "^5.2.0",
-    "@nrwl/cli": "13.8.2",
-    "@nrwl/devkit": "13.8.2",
-    "@nrwl/eslint-plugin-nx": "13.8.2",
-    "@nrwl/jest": "13.8.2",
-    "@nrwl/js": "13.8.2",
-    "@nrwl/linter": "13.8.2",
-    "@nrwl/node": "^13.8.2",
-    "@nrwl/tao": "13.8.2",
-    "@nrwl/workspace": "13.8.2",
+    "@jscutlery/semver": "^5.3.1",
+    "@nx/devkit": "20.0.0",
+    "@nx/eslint": "20.0.0",
+    "@nx/eslint-plugin": "20.0.0",
+    "@nx/jest": "20.0.0",
+    "@nx/js": "20.0.0",
+    "@nx/node": "20.0.0",
+    "@nx/workspace": "20.0.0",
     "@open-wc/webpack-import-meta-loader": "^0.4.7",
     "@types/jest": "27.0.2",
+    "@types/jest-when": "^3.5.2",
     "@types/node": "16.11.7",
     "@types/require-from-string": "^1.2.1",
     "@typescript-eslint/eslint-plugin": "~5.10.0",
-    "@types/jest-when": "^3.5.2",
-    "jest-when": "^3.6.0",
     "@typescript-eslint/parser": "~5.10.0",
     "babel-loader": "^8.2.3",
     "commitiquette": "^1.2.1",
@@ -60,9 +58,10 @@
     "eslint-config-prettier": "8.1.0",
     "eslint-plugin-simple-import-sort": "^7.0.0",
     "html-webpack-plugin": "^5.5.0",
-    "husky": "^7.0.4",
+    "husky": "^9.0.0",
     "is-ci": "^3.0.1",
     "jest": "27.2.3",
+    "jest-when": "^3.6.0",
     "lint-staged": "^12.3.4",
     "node-polyfill-webpack-plugin": "^1.1.4",
     "prettier": "^2.5.1",

diff --git a/packages/approval-signing-manager/project.json b/packages/approval-signing-manager/project.json
@@ -1,10 +1,12 @@
 {
-  "root": "packages/approval-signing-manager",
+  "name": "@polymeshassociation/approval-signing-manager",
+  "$schema": "../../node_modules/nx/schemas/project-schema.json",
   "sourceRoot": "packages/approval-signing-manager/src",
   "projectType": "library",
+  "tags": [],
   "targets": {
     "build": {
-      "executor": "@nrwl/node:package",
+      "executor": "@nx/node:package",
       "outputs": ["{options.outputPath}"],
       "options": {
         "outputPath": "dist/packages/approval-signing-manager",
@@ -16,36 +18,33 @@
       }
     },
     "lint": {
-      "executor": "@nrwl/linter:eslint",
+      "executor": "@nx/linter:eslint",
       "outputs": ["{options.outputFile}"],
       "options": {
         "lintFilePatterns": ["packages/approval-signing-manager/**/*.ts"]
       }
     },
     "test": {
-      "executor": "@nrwl/jest:jest",
+      "executor": "@nx/jest:jest",
       "outputs": ["coverage/packages/approval-signing-manager"],
       "options": {
         "jestConfig": "packages/approval-signing-manager/jest.config.js",
         "passWithNoTests": true
       }
     },
-    "release": {
-      "executor": "@ng-easy/builders:semantic-release",
-      "configurations": {
-        "local": {
-          "force": true
-        }
-      }
-    },
     "run-local": {
       "executor": "./tools/executors/run-local:run-local",
       "options": {
         "runInBrowser": false,
         "path": "packages/approval-signing-manager/sandbox/index.ts",
         "port": 9000
       }
+    },
+    "version": {
+      "executor": "@jscutlery/semver:version",
+      "options": {
+        "preset": "conventionalcommits"
+      }
     }
-  },
-  "tags": []
+  }
 }
diff --git a/packages/azure-signing-manager/CHANGELOG.md b/packages/azure-signing-manager/CHANGELOG.md
diff --git a/packages/azure-signing-manager/README.md b/packages/azure-signing-manager/README.md
@@ -1,7 +1,6 @@
 # azure-signing-manager
 
-Polymesh SDK compatible signing manager. This allows Polymesh transactions to be signed with keys in an Microsoft Azure [key vault](https://azure.microsoft.com/en-us/products/key-vault). The keys must be "EC"
-type and use curve "P-256K". The signing manager will ignore any other type.
+Polymesh SDK compatible signing manager. This allows Polymesh transactions to be signed with keys in an Microsoft Azure [key vault](https://azure.microsoft.com/en-us/products/key-vault). The keys must be "EC" type and use curve "P-256K". The signing manager will ignore any other type.
 
 ## Usage
 
@@ -36,15 +35,7 @@ interface {
 }
 ```
 
-For now it is recommended to have a key vault dedicated to Polymesh keys. Please open an issue if you performing the additional work is worth having thousands of keys stored.
-
-For Reference - Azure key vault pricing ($USD), October 2024:
-```
-First 250 keys 	        $5 per key per month
-From 251 – 1,500 keys 	$2.50 per key per month
-From 1,501 – 4,000 keys $0.90 per key per month
-4,001+ keys 	          $0.40 per key per month
-```
+For now it is recommended to have a key vault dedicated to Polymesh keys and to keep them to a limited number. Please open an issue if you desire thousands of keys stored in an Azure key vault.
 
 ## Running unit tests
 

diff --git a/packages/azure-signing-manager/project.json b/packages/azure-signing-manager/project.json
@@ -1,7 +1,9 @@
 {
-  "root": "packages/azure-signing-manager",
+  "name": "@polymeshassociation/azure-signing-manager",
+  "$schema": "../../node_modules/nx/schemas/project-schema.json",
   "sourceRoot": "packages/azure-signing-manager/src",
   "projectType": "library",
+  "tags": [],
   "targets": {
     "build": {
       "executor": "@nrwl/node:package",
@@ -16,36 +18,33 @@
       }
     },
     "lint": {
-      "executor": "@nrwl/linter:eslint",
+      "executor": "@nx/linter:eslint",
       "outputs": ["{options.outputFile}"],
       "options": {
         "lintFilePatterns": ["packages/azure-signing-manager/**/*.ts"]
       }
     },
     "test": {
-      "executor": "@nrwl/jest:jest",
+      "executor": "@nx/jest:jest",
       "outputs": ["coverage/packages/azure-signing-manager"],
       "options": {
         "jestConfig": "packages/azure-signing-manager/jest.config.js",
         "passWithNoTests": true
       }
     },
-    "release": {
-      "executor": "@ng-easy/builders:semantic-release",
-      "configurations": {
-        "local": {
-          "force": true
-        }
-      }
-    },
     "run-local": {
       "executor": "./tools/executors/run-local:run-local",
       "options": {
         "runInBrowser": false,
         "path": "packages/azure-signing-manager/sandbox/index.ts",
         "port": 9000
       }
+    },
+    "version": {
+      "executor": "@jscutlery/semver:version",
+      "options": {
+        "preset": "conventionalcommits"
+      }
     }
-  },
-  "tags": []
+  }
 }
diff --git a/packages/browser-extension-signing-manager/project.json b/packages/browser-extension-signing-manager/project.json
@@ -1,10 +1,12 @@
 {
-  "root": "packages/browser-extension-signing-manager",
+  "name": "@polymeshassociation/browser-extension-signing-manager",
+  "$schema": "../../node_modules/nx/schemas/project-schema.json",
   "sourceRoot": "packages/browser-extension-signing-manager/src",
   "projectType": "library",
+  "tags": [],
   "targets": {
     "build": {
-      "executor": "@nrwl/node:package",
+      "executor": "@nx/node:package",
       "outputs": ["{options.outputPath}"],
       "options": {
         "outputPath": "dist/packages/browser-extension-signing-manager",
@@ -16,36 +18,33 @@
       }
     },
     "lint": {
-      "executor": "@nrwl/linter:eslint",
+      "executor": "@nx/linter:eslint",
       "outputs": ["{options.outputFile}"],
       "options": {
         "lintFilePatterns": ["packages/browser-extension-signing-manager/**/*.ts"]
       }
     },
     "test": {
-      "executor": "@nrwl/jest:jest",
+      "executor": "@nx/jest:jest",
       "outputs": ["coverage/packages/browser-extension-signing-manager"],
       "options": {
         "jestConfig": "packages/browser-extension-signing-manager/jest.config.js",
         "passWithNoTests": true
       }
     },
-    "release": {
-      "executor": "@ng-easy/builders:semantic-release",
-      "configurations": {
-        "local": {
-          "force": true
-        }
-      }
-    },
     "run-local": {
       "executor": "./tools/executors/run-local:run-local",
       "options": {
         "runInBrowser": false,
         "path": "packages/browser-extension-signing-manager/sandbox/index.ts",
         "port": 9000
       }
+    },
+    "version": {
+      "executor": "@jscutlery/semver:version",
+      "options": {
+        "preset": "conventionalcommits"
+      }
     }
-  },
-  "tags": []
+  }
 }
diff --git a/packages/fireblocks-signing-manager/project.json b/packages/fireblocks-signing-manager/project.json
@@ -1,10 +1,12 @@
 {
-  "root": "packages/fireblocks-signing-manager",
+  "name": "@polymeshassociation/fireblocks-signing-manager",
+  "$schema": "../../node_modules/nx/schemas/project-schema.json",
   "sourceRoot": "packages/fireblocks-signing-manager/src",
   "projectType": "library",
+  "tags": [],
   "targets": {
     "build": {
-      "executor": "@nrwl/node:package",
+      "executor": "@nx/node:package",
       "outputs": ["{options.outputPath}"],
       "options": {
         "outputPath": "dist/packages/fireblocks-signing-manager",
@@ -16,27 +18,22 @@
       }
     },
     "lint": {
-      "executor": "@nrwl/linter:eslint",
+      "executor": "@nx/linter:eslint",
       "outputs": ["{options.outputFile}"],
       "options": {
         "lintFilePatterns": ["packages/fireblocks-signing-manager/**/*.ts"]
       }
     },
     "test": {
-      "executor": "@nrwl/jest:jest",
+      "executor": "@nx/jest:jest",
       "outputs": ["coverage/packages/fireblocks-signing-manager"],
       "options": {
         "jestConfig": "packages/fireblocks-signing-manager/jest.config.js",
         "passWithNoTests": true
       }
     },
     "release": {
-      "executor": "@ng-easy/builders:semantic-release",
-      "configurations": {
-        "local": {
-          "force": true
-        }
-      }
+      "executor": "@theunderscorer/nx-semantic-release:semantic-release"
     },
     "run-local": {
       "executor": "./tools/executors/run-local:run-local",
@@ -45,7 +42,12 @@
         "path": "packages/fireblocks-signing-manager/sandbox/index.ts",
         "port": 9000
       }
+    },
+    "version": {
+      "executor": "@jscutlery/semver:version",
+      "options": {
+        "preset": "conventionalcommits"
+      }
     }
-  },
-  "tags": []
+  }
 }