Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tags not applied #83

Merged
merged 1 commit into from
Jul 20, 2023
Merged

fix: tags not applied #83

merged 1 commit into from
Jul 20, 2023

Conversation

sansan
Copy link
Contributor

@sansan sansan commented Jul 20, 2023

@sansan sansan requested a review from a team as a code owner July 20, 2023 07:55
polymath-eric
polymath-eric reviewed Jul 20, 2023
View reviewed changes
Copy link
Contributor

@polymath-eric polymath-eric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure how this would fix the issue of not adding tags, only give us more accurate errors. Maybe I am missing something.

I am OK with merging for better info, but the PR title says fix in it

apps/cdd-backend/src/mailchimp/mailchimp.service.ts Show resolved Hide resolved
polymath-eric
polymath-eric previously approved these changes Jul 20, 2023
View reviewed changes
@polymath-eric polymath-eric merged commit 52d35ed into main Jul 20, 2023
3 checks passed
@polymath-eric polymath-eric deleted the fix/mailchimp-tags branch July 20, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polymath-eric polymath-eric polymath-eric approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sansan @polymath-eric