handle no new netki codes in a page

PolymeshAssociation · Jul 8, 2024 · 6150013 · 6150013
1 parent 045328a
commit 6150013
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 2 deletions.
diff --git a/apps/cdd-backend/src/netki/netki.service.spec.ts b/apps/cdd-backend/src/netki/netki.service.spec.ts
@@ -137,6 +137,34 @@ describe('NetkiService', () => {
       ]);
     });
 
+    it('should not call redis if no new codes are added', async () => {
+      const mockResponse = {
+        data: {
+          results: [
+            {
+              id: '345',
+              code: 'def',
+              created: new Date().toISOString(),
+              parent_code: null,
+            },
+          ],
+        },
+      } as AxiosResponse;
+
+      jest.spyOn(mockHttp, 'get').mockImplementation(() => of(mockResponse));
+      jest
+        .spyOn(mockHttp, 'post')
+        .mockImplementation(() => of(mockAccessResponse));
+
+      mockRedis.getAllocatedNetkiCodes.mockResolvedValue(new Set(['def']));
+      mockRedis.pushNetkiCodes.mockResolvedValue(1);
+
+      const result = await service.fetchAccessCodes();
+
+      expect(result).toEqual({ added: 0, total: 2 });
+      expect(mockRedis.pushNetkiCodes).not.toHaveBeenCalled();
+    });
+
     it('should loop through all of the pages', async () => {
       const mockPageOne = {
         data: {

diff --git a/apps/cdd-backend/src/netki/netki.service.ts b/apps/cdd-backend/src/netki/netki.service.ts
@@ -153,8 +153,10 @@ export class NetkiService {
           isActive,
         }));
 
-      const codesAdded = await this.redis.pushNetkiCodes(newLinks);
-      added += codesAdded;
+      if (newLinks.length) {
+        const codesAdded = await this.redis.pushNetkiCodes(newLinks);
+        added += codesAdded;
+      }
 
       if (codeResponse.data.next) {
         url = codeResponse.data.next;