Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to mask/reveal/hide by polygons #263

Merged
merged 24 commits into from
Sep 16, 2024
Merged

Add support to mask/reveal/hide by polygons #263

merged 24 commits into from
Sep 16, 2024

Conversation

tpoisot
Copy link
Member

@tpoisot tpoisot commented Sep 15, 2024

Closes #231

Copy link
Contributor

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 42 lines in your changes missing coverage. Please review.

Project coverage is 53.81%. Comparing base (7caf2b1) to head (4b9be6f).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
src/polygons.jl 0.00% 37 Missing ⚠️
src/integrations/makie.jl 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #263      +/-   ##
==========================================
+ Coverage   52.71%   53.81%   +1.10%     
==========================================
  Files          59       59              
  Lines        1713     1546     -167     
==========================================
- Hits          903      832      -71     
+ Misses        810      714      -96     
Flag Coverage Δ
unittests 53.81% <0.00%> (+1.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tpoisot
Copy link
Member Author

tpoisot commented Sep 15, 2024

So the proof of concept is working, now this needs to fully respect the GeoJSON spec - this means holes and multipolygons

@tpoisot tpoisot merged commit e11c0e1 into main Sep 16, 2024
13 of 14 checks passed
@tpoisot tpoisot deleted the feat/sdt/polygon branch September 16, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Masking/segmentating layer based on vector
2 participants