Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect match reqs #6

Merged
merged 42 commits into from
Sep 8, 2024
Merged

Connect match reqs #6

merged 42 commits into from
Sep 8, 2024

Conversation

louonezime
Copy link
Collaborator

@louonezime louonezime commented Jul 17, 2024

Description

Please provide a detailed description of what was done in this PR.
Precise the issue that you are resolving.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it.

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the needed labels
  • I have linked this PR to an issue
  • I have linked this PR to a milestone
  • I have linked this PR to a project
  • I have tested this code
  • I have added / updated tests (unit / functional / end-to-end / ...)
  • I have updated the README and other relevant documents (guides...)
  • I have added sufficient documentation both in code, as well as in the READMEs

Additional comments

Please post additional comments in this section if you have them, otherwise delete it.

57ave and others added 26 commits May 31, 2024 17:05
Gustave/request to Connect to Init-Matching adapted
@louonezime louonezime added this to the matching milestone Jul 23, 2024
src/cli/cli.go Outdated

if params.Workers < 1 {
return params, ThreadsError
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a worker limit

src/cli/cli.go Outdated Show resolved Hide resolved
src/main.go Outdated Show resolved Hide resolved
@louonezime louonezime linked an issue Aug 31, 2024 that may be closed by this pull request
@louonezime louonezime removed the request for review from adamdeziri September 8, 2024 16:20
@louonezime louonezime merged commit 25108c5 into main Sep 8, 2024
1 check passed
@louonezime louonezime linked an issue Sep 8, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Crash when the site is not reached [Bug]: infinite loop at the end of the comp
4 participants