-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds hover images and toggle setting to gameUI #515
base: master
Are you sure you want to change the base?
Conversation
One detail from the feature request that I've omitted is the instructional text below the previewed card's image. It seemed incongruous with GEMP's minimalist approach. Open to implementing in some fashion in a subsequent PR. |
Hello, @stbly . git remote add upstream [email protected]:PlayersCommittee/gemp-swccg-public.git
git fetch upstream
git merge upstream/master
git mergetool gemp-swccg-async/src/main/web/js/gemp-016/gameUi.js
mvn clean install It is also difficult to see specifically what you are changing as your pull request has made many formatting changes in |
@stbly , in testing this pull request I observed that the when pressing "shift" so I could click the image and get the card details, the card flips vertically. Is it possible to suppress that action? |
It's on purpose that holding down SHIFT rotates the card (or flips it if it's a double-sided card), so that you can easily read the text on the other side of a location or flip side of an objective, for example. Stbly didn't include the instructional text/image under the preview that explains this. But I also see a minor error in the implementation: When you move over a location, the preview should be facing in the same direction as the card on table. When you move over the Tatooine location, it's facing dark side towards the player, but should be facing light side towards the player like the card on table. My original implementation did this (though it would just copy the orientation of any card on table, so should just be limited to locations). |
@stbly , if you can get the latest gemp changes merged in to your PR I will merge your PR. Thanks. |
Implements feature detailed here: #466