Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds hover images and toggle setting to gameUI #515

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stbly
Copy link
Contributor

@stbly stbly commented Feb 7, 2022

Implements feature detailed here: #466

  • Adds preview image logic in gameUI.js
  • Adds a setting to toggle functionality on/off
  • Adds a css class to all cards being animated by gameAnimations.js so that animating cards can be ignored by preview image logic

hover mp4

@stbly
Copy link
Contributor Author

stbly commented Feb 7, 2022

One detail from the feature request that I've omitted is the instructional text below the previewed card's image. It seemed incongruous with GEMP's minimalist approach. Open to implementing in some fashion in a subsequent PR.

@DevoKun
Copy link
Contributor

DevoKun commented May 17, 2022

Hello, @stbly .
I pulled down your pull request and was unable to get it to build locally.
Please merge the latest code in to your branch from upstream and ensure that it builds successfully with: mvn clean install.

git remote add upstream [email protected]:PlayersCommittee/gemp-swccg-public.git
git fetch upstream
git merge upstream/master
git mergetool  gemp-swccg-async/src/main/web/js/gemp-016/gameUi.js
mvn clean install

It is also difficult to see specifically what you are changing as your pull request has made many formatting changes in gameUI.js. Although many of the changes appear warranted, I would ask that you make a pull reqou fuest for the syntax fixes which is separate from the new image hover feature so that it can be more easily reviewed.
Thank you for your code contribution!

@DevoKun DevoKun added the enhancement New feature or request label May 17, 2022
@DevoKun
Copy link
Contributor

DevoKun commented May 17, 2022

@stbly , in testing this pull request I observed that the when pressing "shift" so I could click the image and get the card details, the card flips vertically. Is it possible to suppress that action?

hover2 mp4

@chrknudsen
Copy link

chrknudsen commented Jun 8, 2022

It's on purpose that holding down SHIFT rotates the card (or flips it if it's a double-sided card), so that you can easily read the text on the other side of a location or flip side of an objective, for example. Stbly didn't include the instructional text/image under the preview that explains this.

But I also see a minor error in the implementation: When you move over a location, the preview should be facing in the same direction as the card on table. When you move over the Tatooine location, it's facing dark side towards the player, but should be facing light side towards the player like the card on table. My original implementation did this (though it would just copy the orientation of any card on table, so should just be limited to locations).

@DevoKun DevoKun removed the request for review from EchoBaseTrooper October 3, 2023 00:56
@DevoKun
Copy link
Contributor

DevoKun commented Oct 3, 2023

@stbly , if you can get the latest gemp changes merged in to your PR I will merge your PR. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants