Add shell completions to wrapper #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bash, fish, zsh supported
|
This doesn't work on macOS (using the default shell, |
srid
commented
Dec 20, 2022
There was a problem hiding this comment.
This PR needs a few changes before being considered for merge:
- If zsh completions are not tested to work (especially on macOS, which they do not), they should be removed entirely.
- Ideally we would fix macOS zsh completion in this PR, but this can also happen in a separate PR.
- The entire completion code should be factored out of
wrapper.nixinto its own file, especially as the fish/zsh completions are looking to be complex. That Nix file should take a list of strings (program name and subcommands) and return the shell completion spec for them.
| @@ -48,13 +50,76 @@ let | |||
| fi | |||
| ''; | |||
| }; | |||
| sanitizedWrapperName = | |||
There was a problem hiding this comment.
Need a comment here explaining why we need this sanitization in the first place. Is it because one or more of the shells can't work with special characters like ,, or?
|
Closing. cf. db46f39 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bash, fish, zsh supported
Ref #4