Merge device-pkgs repo into the pallet, to simplify the developer experience #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to simplify the process of making/testing changes to Docker apps (such as the PlanktoScope backend's segmenter) by merging https://github.com/PlanktoScope/device-pkgs into this pallet. Specifically, this PR moves all packages from the device-pkgs repo into this pallet, so that modifying a package can be done directly in a PR on this pallet, without the need to make a separate PR on a separate GitHub repo (the device-pkgs repo) and to run a
forklift dev plt require-repo github.com/PlanktoScope/device-pkgs@{branch name}command in the PR on this pallet.This PR is made with the idea that people customizing the pallet will use pallet layering (i.e. requiring this pallet and importing all files from this pallet and then adding override files) rather than Git repo forking. Pallet layering is added by prereleases v0.8.0-alpha.1 and v0.8.0-alpha.2 of the
forklifttool.