Refactor everything #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors everything in the core implementation of Forklift (i.e. excluding the Git and Docker drivers) based on what was learned from prototyping the Forklift tool. Some code is moved out to a new
github.com/PlanktoScope/pkg/palletspublic package, and a previous restriction on defining Pallet package deployments only in the top level of thedeploymentsdirectory of any Forklift environment has now been relaxed (so that deployments can be defined anywhere underneath thedeploymentsdirectory). Any other observable changes are accidental breakages/bugs rather than intentional features.