Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch from all remotes as part of checking whether local pallet is backed up #306

Merged
merged 2 commits into from
Sep 21, 2024

Conversation

ethanjli
Copy link
Member

@ethanjli ethanjli commented Sep 21, 2024

This PR fixes a bug in plt switch and plt upgrade where that command fails under the following conditions, even though it should succeed:

  1. The remote Git repo (e.g. on GitHub) has new commits.
  2. The plt switch or plt upgrade command is run when the local pallet has not yet fetched those new commits.

This bug is probably a regression introduced by #266.

@ethanjli ethanjli marked this pull request as ready for review September 21, 2024 21:50
@ethanjli ethanjli added this pull request to the merge queue Sep 21, 2024
Merged via the queue into main with commit 245b912 Sep 21, 2024
4 checks passed
@ethanjli ethanjli deleted the fix/plt-switch-fetch branch September 21, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

1 participant