Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TfMallocTag.Tls.Find static method on Darwin. #3292

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

furby-tm
Copy link
Contributor

@furby-tm furby-tm commented Sep 15, 2024

The original reasoning for disabling this was because originally thread_local was not available in Apple's (now ancient) Clang pre-Xcode 8, however now all modern versions of Apple's Clang do have support for thread_local.

Description of Change(s)

  • The static method for TfMallocTag::Tls::Find() now returns the per-thread data for TfMallocTag on all Darwin platforms, which before this change, has always returned nothing (and was silently failing).
  • Remove the ARCH_HAS_THREAD_LOCAL preprocessor.
  • Remove any/all conditional compilation checks for ARCH_HAS_THREAD_LOCAL.

Note

I had noticed the following two Tf test cases are failing, but this is unrelated to this revision, as they were failing before this revision was introduced.

99% tests passed, 2 tests failed out of 791

Total Test time (real) = 1495.16 sec

The following tests FAILED:
	 15 - TfAtomicOfstreamWrapper (Failed)
	 56 - TfSafeOutputFile (Failed)

Fixes Issue(s)

  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

* Also remove the ARCH_HAS_THREAD_LOCAL preprocessor
  and any/all conditional compilation checks for this value.

Signed-off-by: furby™ <[email protected]>
@furby-tm furby-tm changed the base branch from release to dev September 15, 2024 04:01
@furby-tm furby-tm changed the title Fix TfMalocTag.Tls.Find() static method on Darwin. Fix TfMalocTag.Tls.Find static method on Darwin. Sep 15, 2024
@furby-tm furby-tm changed the title Fix TfMalocTag.Tls.Find static method on Darwin. Fix TfMallocTag.Tls.Find static method on Darwin. Sep 15, 2024
@furby-tm
Copy link
Contributor Author

(cc. @dgovil, @AlexSchwank), I was not able to locate Nicholas Blasingame's GitHub username, but feel free to ping him here to sync up, thanks!

@jesschimein
Copy link
Contributor

Filed as internal issue #USD-10127

@jesschimein
Copy link
Contributor

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dgovil dgovil added the needs review Issue needing input/review by the repo maintainer (Pixar) label Nov 7, 2024
@dgovil
Copy link
Collaborator

dgovil commented Nov 7, 2024

Another one that we talked about on slack but I forgot to respond here. This looks like a good change to me. Thanks for solving that.

@jesschimein
Copy link
Contributor

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review Issue needing input/review by the repo maintainer (Pixar)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants