Fix TfMallocTag.Tls.Find static method on Darwin. #3292
+0
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original reasoning for disabling this was because originally
thread_local
was not available in Apple's (now ancient) Clang pre-Xcode 8, however now all modern versions of Apple's Clang do have support forthread_local
.Description of Change(s)
TfMallocTag::Tls::Find()
now returns the per-thread data forTfMallocTag
on all Darwin platforms, which before this change, has always returned nothing (and was silently failing).ARCH_HAS_THREAD_LOCAL
preprocessor.ARCH_HAS_THREAD_LOCAL
.Note
I had noticed the following two Tf test cases are failing, but this is unrelated to this revision, as they were failing before this revision was introduced.
Fixes Issue(s)