Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nanocolor: fix namespace and symbol leaks #3281

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

nanocolor: fix namespace and symbol leaks #3281

wants to merge 1 commit into from
+11 −8

Conversation

rpoyner-tri
Copy link

Description of Change(s)

  • Extend the project-wide namespace scheme to nanocolor
  • Make the pxr.h header plain-C compatible to help with the above
  • Mark some C-file-only functions static

Fixes Issue(s)

Partial fix for #3279.

  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@rpoyner-tri rpoyner-tri mentioned this pull request Sep 9, 2024
Merged
@jesschimein
Copy link
Contributor

Filed as internal issue #USD-10096

@jesschimein
Copy link
Contributor

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

pixar-oss pushed a commit that referenced this pull request Sep 18, 2024
@meshula @pixar-oss
nanocolor: fix namespace and symbol leaks
8375ec8 
- Use ARCH_HIDDEN to hide nanocolor symbols
- Mark some C-file-only functions `static`, and name all static functions consistently.

Partial fix for #3279.

See #3281

(Internal change: 2341118)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rpoyner-tri @jesschimein