Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to fix an issue with the MergingSceneIndex. #3263

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Attempt to fix an issue with the MergingSceneIndex. #3263

wants to merge 1 commit into from

Commits on Aug 30, 2024

  1. Attempt to fix an issue with the MergingSceneIndex. 

    When triggering a "whole scene" removal, this scene index can cause the
whole scene to be "added", and nothing to be "removed", which is a
problem. This can be triggered by the removeal of a sublayer from the
stage. This way of handling the change causes accesses to expired
UsdPrims, which throw exceptions.

This commit attempts to be more precise about the add and remove changes
sent in this situation by "adding" prims that are still in any merged scene
index, and "removing" any prims that exist only in the scene index that
triggered the change. This can result in a _lot_ of small changes instead
of one big change, so there may be a need to optimize this, but I think the
principle is correct (and the commit does prevent the invlid UsdPrim access
exceptions).
    @marktucker
    marktucker committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    a205aa7 View commit details
    Browse the repository at this point in the history