-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add tools mariadb client 5.5.68 #479
feat: add tools mariadb client 5.5.68 #479
Conversation
for more information, see https://pre-commit.ci
Based on the pull request, the key changes are:
Regarding potential problems or issues, there are a few things to consider:
To address these potential issues, you could take the following steps:
Overall, the pull request seems to be adding useful functionality to the Dockerfile. However, it's important to carefully evaluate the changes to ensure that they don't introduce any unexpected problems or conflicts. |
Based on the Pull Request description and the diff, it seems that the pull request adds the MariaDB client version 5.5.68 to the CI/CD base Docker image. The change involves downloading and installing the specified version of MariaDB client for the amd64 architecture if it is supported. One potential problem with this pull request is that it only supports the amd64 architecture. If the Docker image is built on a different architecture, the installation step will fail. In this case, the pull request does not provide any fallback or alternative installation steps. To fix this issue, one solution could be to check the architecture of the Docker image before downloading and installing the MariaDB client. If it is not supported, the script could exit with an appropriate error message. Another suggestion to improve the pull request is to include a version check before installing the MariaDB client. This check will ensure that the version specified in the pull request is not already installed, preventing unnecessary installations. Overall, the pull request seems to be a reasonable addition to the CI/CD base Docker image, but some improvements can be made to make the installation step more robust and error-proof. |
…/artifacts into purelind/update-ci-jenins-image
Based on the pull request, the key changes are:
One potential problem that can be identified is that the script only checks for amd64 architecture to proceed with the installation of mariadb. This means that the installation will only work for this specific architecture and may cause issues for other architectures. It would be better to add support for multiple architectures to ensure compatibility. To fix this, the script could be updated to include checks for other architectures as well. For example, the script could check for arm64 architecture and proceed with installation accordingly. Additionally, it would be good to add tests to ensure that the installation works as expected for each architecture. Overall, the pull request looks good, but the issue with only supporting one architecture should be addressed. |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Install mysql client from mariadb v5.5.68.