Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(dockerfiles/cd/pingcap/tidb): update it to real CD's builder and building stages #121

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

wuhuizuo
Copy link
Contributor

No description provided.

@ti-chi-bot ti-chi-bot bot requested review from jayl1e and purelind November 13, 2023 08:58
Copy link

ti-chi-bot bot commented Nov 13, 2023

I have already done a preliminary review for you, and I hope to help you do a better job.
Pull Request Review

Summary:

The pull request is a refactoring of the Dockerfile of PingCAP TiDB. It updates the real CD's builder and building stages.

Key Changes:

  • The tidb/Dockerfile file is deleted, and a new Dockerfile called cd/pingcap/tidb/Dockerfile is added.
  • A new stage called Builder is added to the new Dockerfile.
  • The busybox container is copied from the busybox:1.36.1 container to the pingcap-base container.
  • The tidb-base container is copied from the ghcr.io/pingcap-qe/bases/tidb-base:v1.7.1 container.
  • The ARG variable GOLANG_VERSION is added to the new Dockerfile.

Potential Problems:

  • The pull request does not have any descriptive information in the description section.
  • In the msb-tidb target, the docker run command is replaced with the docker build command, which may cause issues in the future.
  • The busybox container is copied from a specific version (busybox:1.36.1). It should be reviewed whether the specific version is suitable or not.
  • The ARG variable GOLANG_VERSION is added to the new Dockerfile, but there is no information about it in the description section.

Fixing Suggestions:

  • The pull request should include a description of the changes made to the code.
  • The msb-tidb target should use the docker run command instead of docker build command.
  • The busybox container should be reviewed to see if the specific version (busybox:1.36.1) is suitable or not. If not, it should be replaced with a suitable version.
  • The ARG variable GOLANG_VERSION should be added to the pull request's description section.

@ti-chi-bot ti-chi-bot bot added the size/L label Nov 13, 2023
Copy link

ti-chi-bot bot commented Nov 13, 2023

I have already done a preliminary review for you, and I hope to help you do a better job.
Pull Request Review

The pull request updates the Dockerfile for TIDB's continuous deployment. The changes include updating the Dockerfile to the latest continuous deployment builder and building stages.

Suggestions:

There are no issues with this pull request. It is a straightforward update of the Dockerfile that will enhance the continuous deployment of TIDB. The changes made in this pull request are good, and they should be merged into the TIDB repository.

@ti-chi-bot ti-chi-bot bot added size/M and removed size/L labels Nov 13, 2023
@wuhuizuo
Copy link
Contributor Author

/approve

Copy link

ti-chi-bot bot commented Nov 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 13, 2023
@ti-chi-bot ti-chi-bot bot merged commit 2146149 into main Nov 13, 2023
2 checks passed
@ti-chi-bot ti-chi-bot bot deleted the feature/msb-tidb branch November 13, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant