Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert robotiq_gripper_controller type until antipodal controller becomes available #48

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

adlarkin
Copy link
Contributor

@adlarkin adlarkin commented Mar 4, 2024

Reverting this change that was made in #44 since the antipodal_gripper_action_controller is not available for use yet.

I also initialized the hardware interface drivers to 0.0, as suggested in Kinovarobotics/ros2_kortex#204 (comment)

@adlarkin adlarkin requested a review from pac48 March 4, 2024 17:08
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 20.29%. Comparing base (743d20f) to head (f73c0e5).
Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##            main      #48       +/-   ##
==========================================
+ Coverage   0.00%   20.29%   +20.29%     
==========================================
  Files          5       20       +15     
  Lines        352      611      +259     
  Branches       0      250      +250     
==========================================
+ Hits           0      124      +124     
+ Misses       352      347        -5     
- Partials       0      140      +140     
Flag Coverage Δ
unittests 20.29% <ø> (+20.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pac48
pac48 previously approved these changes Mar 4, 2024
Copy link
Collaborator

@pac48 pac48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

Copy link
Collaborator

@pac48 pac48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adlarkin adlarkin merged commit b6136bd into main Mar 4, 2024
19 checks passed
@delete-merged-branch delete-merged-branch bot deleted the revert_gripper_controller_type branch March 4, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants