Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump version of always-upload-cache #46

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

bump version of always-upload-cache #46

wants to merge 4 commits into from

Conversation

moriarty
Copy link
Contributor

I don't think this will fix the issue I think the issue is due to name: But I can't find github action documentation to back that up

I don't think this will fix the issue I think the issue is due to `name:`
But I can't find github action documentation to back that up

Signed-off-by: Alexander Moriarty <[email protected]>
@moriarty moriarty requested a review from pac48 February 15, 2024 02:55
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: 434 lines in your changes are missing coverage. Please review.

Comparison is base (743d20f) 0.00% compared to head (ce1b0db) 20.29%.
Report is 16 commits behind head on main.

Files Patch % Lines
robotiq_driver/src/default_driver.cpp 9.09% 120 Missing ⚠️
robotiq_driver/src/hardware_interface.cpp 10.28% 70 Missing and 26 partials ⚠️
robotiq_driver/src/fake/fake_driver.cpp 0.00% 35 Missing ⚠️
robotiq_driver/src/default_serial.cpp 22.72% 32 Missing and 2 partials ⚠️
...botiq_driver/tests/test_default_driver_factory.cpp 34.28% 0 Missing and 23 partials ⚠️
robotiq_driver/src/default_driver_factory.cpp 26.66% 3 Missing and 19 partials ⚠️
robotiq_driver/src/default_serial_factory.cpp 29.16% 0 Missing and 17 partials ⚠️
..._controllers/src/robotiq_activation_controller.cpp 0.00% 15 Missing ⚠️
robotiq_driver/src/data_utils.cpp 55.88% 3 Missing and 12 partials ⚠️
...botiq_driver/tests/test_default_serial_factory.cpp 44.44% 0 Missing and 15 partials ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##            main      #46       +/-   ##
==========================================
+ Coverage   0.00%   20.29%   +20.29%     
==========================================
  Files          5       20       +15     
  Lines        352      611      +259     
  Branches       0      250      +250     
==========================================
+ Hits           0      124      +124     
+ Misses       352      347        -5     
- Partials       0      140      +140     
Flag Coverage Δ
unittests 20.29% <20.80%> (+20.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@moriarty
Copy link
Contributor Author

Looks like this has been broken for some time, but was working at some point...
Because they're failing on old open PRs too.

The CI jobs were added in this PR and setup and configured using a script, I might need to re-run that script

#29

@moriarty
Copy link
Contributor Author

image
image

https://github.com/orgs/community/discussions/26698

Ahh this is likely an issue in the project configuration which broke at some point due to refactoring or renaming... I'll check the settings

@moriarty
Copy link
Contributor Author

image

The names that come up in the settings search menu and how the jobs are named seems to have changed or was always incorrect I have removed the expected checks for now.

Humble Binary Build - main / binary / humble main (pull_request)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants