-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[photon-lib] Sim multitag result #973
Merged
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
d671236
update multitag result
amquake 78bbd19
Merge branch 'master' into sim-multitag
amquake e531236
hide ATFL setter
amquake cfcc120
Merge branch 'master' into sim-multitag
amquake f2cbc90
tag layout as field
amquake 9b4001e
Merge branch 'master' into sim-multitag
amquake 0400cf1
Merge branch 'master' into sim-multitag
amquake File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is kinda weird... I'm not sure of a better way to do this since we need the ATFL to calculate the multitag result. This does not check what layout the coprocessor has, just the last one set from user code. All coprocessors on a NT instance share the same tag layout (and updating the layout through one camera should mean the others also can get that updated layout), but this uses a static field and technically assumes all coprocessors are on the same NT instance.
It could exist in
PhotonCameraSim
instead, but that would require code duplication specifically for sim when setting a tag layout over NT.The field could also be accessed directly and the getter method removed, but that would require
PhotonCameraSim
to be in the same package asPhotonCamera
.