Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javalin v5 bump #930

Merged
merged 5 commits into from
Oct 5, 2023
Merged

Conversation

srimanachanta
Copy link
Member

closes #867

Might be worth it to look into the SPA section, it may fix the 404 rerouting issues.

look into SpaRootConfig? Potential fix to 404 issues for SPA routing
@srimanachanta srimanachanta requested a review from a team as a code owner October 5, 2023 08:13
var insa = context.session.getRemote().getInetSocketAddress();
var host = insa.getAddress().toString() + ":" + insa.getPort();
context.session.setIdleTimeout(
Duration.ofMillis(Long.MAX_VALUE)); // TODO: determine better value
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feels like a good time to find a better value

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The frontend doesn't even connect to the CameraWebsocket anymore. What from this system is even required anymore?

Copy link
Contributor

@mcm001 mcm001 Oct 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah kill the references here I think. It was from sending camera frames over WS

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot of requests and things in photon-server which aren't used anymore. Like that entire UISettings class

@srimanachanta
Copy link
Member Author

srimanachanta commented Oct 5, 2023

Need to bump slf4j-simple to 2.0.7. That should fix the issues with the log error.

var remote = (InetSocketAddress) ctx.session.getRemoteAddress();
var host =
remote.getAddress().toString() + ":" + remote.getPort();
return "Got WebSockets binary message from host: " + host;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might get spammy, but should be fine since messages going this direction are rare

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And it was already like this

@mcm001 mcm001 merged commit b3a3ab7 into PhotonVision:master Oct 5, 2023
20 checks passed
@srimanachanta srimanachanta deleted the javalin-v5-bump branch October 6, 2023 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Javalin to v5
3 participants