-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Javalin v5 bump #930
Javalin v5 bump #930
Conversation
look into SpaRootConfig? Potential fix to 404 issues for SPA routing
var insa = context.session.getRemote().getInetSocketAddress(); | ||
var host = insa.getAddress().toString() + ":" + insa.getPort(); | ||
context.session.setIdleTimeout( | ||
Duration.ofMillis(Long.MAX_VALUE)); // TODO: determine better value |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feels like a good time to find a better value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The frontend doesn't even connect to the CameraWebsocket anymore. What from this system is even required anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah kill the references here I think. It was from sending camera frames over WS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a lot of requests and things in photon-server which aren't used anymore. Like that entire UISettings class
Need to bump |
var remote = (InetSocketAddress) ctx.session.getRemoteAddress(); | ||
var host = | ||
remote.getAddress().toString() + ":" + remote.getPort(); | ||
return "Got WebSockets binary message from host: " + host; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might get spammy, but should be fine since messages going this direction are rare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And it was already like this
closes #867
Might be worth it to look into the SPA section, it may fix the 404 rerouting issues.