Add Github Action check to make sure template UI is unchanged #918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the behavior of the webserver now if I try to run photon without copying the UI? It was helpful for it to remind me I was being stupid |
I agree with Matt, keeping this empty file here prevents devs from trying to figure out an issue that is just them forgetting to copy the UI over. We have accidentally pushed changes to the file to main (twice iirc) so it might be worth it even to implement an action to ensure it hasn't changed. |
mcm001
force-pushed
the
ignore-index
branch
from
93b9899
to
cf65087
Compare
mcm001
force-pushed
the
ignore-index
branch
2 times, most recently
from
9537e8f
to
5b41ce4
Compare
mcm001
approved these changes
Sep 24, 2023
srimanachanta
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignores index.html created when building UI