Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump python dependencies for 2025 #1567

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

LucienMorey
Copy link
Contributor

I tasked my team with updating our upcoming Reefscape codebase to target 2025 packages, only to realise we have created an unsolvable dependency nightmare with these things being neglected...

@LucienMorey LucienMorey requested a review from a team as a code owner November 13, 2024 07:42
@mcm001
Copy link
Contributor

mcm001 commented Nov 13, 2024

LOL fantastic. Do we need something like photonlib-python-examples to try actually building a robot project automatically for us?

Copy link
Member

@spacey-sooty spacey-sooty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If CI is green Lgtm

@mcm001
Copy link
Contributor

mcm001 commented Nov 13, 2024

Get wpiformatted, nerd

@LucienMorey
Copy link
Contributor Author

Get wpiformatted, nerd

This whole autoformatter thing being broken is making me very sad

@mcm001
Copy link
Contributor

mcm001 commented Nov 13, 2024

It looks like the diff it suggests is reasonable?

@LucienMorey
Copy link
Contributor Author

It looks like the diff it suggests is reasonable?

too much manual formatting with an automatic tool that is giving me bad outputs though

@LucienMorey
Copy link
Contributor Author

LOL fantastic. Do we need something like photonlib-python-examples to try actually building a robot project automatically for us?

Something like this might be good. What would you expect it to look like?

In my head we want to build based on the package published to pypi to get a full closed loop but that will have some lag on it right?

I suppose we could make proper example projects install their dependencies and then try to install this manually and see if it spits the dummy because things are unsolvable?

@mcm001
Copy link
Contributor

mcm001 commented Nov 13, 2024

Pip install . Within the photon lib project and in an isolated clean venv is probably sufficient for a first prototype. Or, we can look at uploading wheels as GitHub actions artifacts and having a subsequent job download and install the wheels without hitting pypi

@LucienMorey
Copy link
Contributor Author

Pip install . Within the photon lib project and in an isolated clean venv is probably sufficient for a first prototype. Or, we can look at uploading wheels as GitHub actions artifacts and having a subsequent job download and install the wheels without hitting pypi

Added a note in the big update issue

mcm001 pushed a commit that referenced this pull request Nov 13, 2024
Signal/noise ratio is too low with this enabled. When dealing with #1567
I got ~46000 lines of errors going around in a circle rather than just
an import failure at the scope of each failed test
@mcm001 mcm001 merged commit a7319ce into PhotonVision:master Nov 13, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants