Update libcamera version #1566
Merged
Update libcamera version #1566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How does this verify that? |
|
Technically it doesn't verify but it will prevent updates to photonvision-libcamera-gl-driver pulling in a version of libcamera that is newer or different from the one in the image we provide. |
mcm001
approved these changes
Nov 14, 2024
|
We desperately do still need to be checking build versions at runtime but sure ship it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the version of libcamera-gl-driver that was built using our image. This verifies that the version of libcamera used in libcamera-gl-driver is the same as the image we provide. This assumes the correct update path of the pi image version to libcamera to photonvision.