Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove wpilibc dependency from vendordep JSON #1543

Closed
wants to merge 1 commit into from
Closed

Remove wpilibc dependency from vendordep JSON #1543

wants to merge 1 commit into from

Conversation

Gold856
Copy link
Contributor

@Gold856 Gold856 commented Nov 10, 2024 •
edited
Loading

JNI shouldn't be linking to wpilibc (cause it also loads things that wpilibj loads.) Although, I think this is just downloading wpilibc, but either way, it shouldn't be a JNI dependency.

@Gold856 Gold856 requested a review from a team as a code owner November 10, 2024 04:20
@mcm001
Copy link
Contributor

mcm001 commented Nov 10, 2024

Hold yer horses. I need to load wpilibc

@spacey-sooty
Copy link
Member

Hold yer horses. I need to load wpilibc

Not for JNI you shouldn't?? why?

mcm001
mcm001 requested changes Nov 10, 2024
View reviewed changes
Copy link
Contributor

@mcm001 mcm001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I do need to load wpilibc. photon-targeting links to wpililbc.

@Gold856
Copy link
Contributor Author

Gold856 commented Nov 10, 2024

The JNI part loads wpilibc? The C++-only component might, but the JNI part seems like it doesn't.

@mcm001
Copy link
Contributor

mcm001 commented Nov 10, 2024 •
edited
Loading

Well either way, for a Java robot project, we need to deploy wpilibc.so. I'm cool with whatever makes sure that gets deployed. photon-targeting uses the wpinet libuv stuff is why, iirc?

@spacey-sooty
Copy link
Member

spacey-sooty commented Nov 10, 2024 •
edited
Loading

photon-targeting uses the wpinet libuv stuff is why, iirc?

that is all seperately linked to wpilibc

@spacey-sooty
Copy link
Member

The JNI part loads wpilibc? The C++-only component might, but the JNI part seems like it doesn't.

photon-targetting-cpp is listed as a JNI dependency...

@spacey-sooty
Copy link
Member

Well either way, for a Java robot project, we need to deploy wpilibc.so.

Why? You shouldn't have to...

@Gold856
Copy link
Contributor Author

Gold856 commented Nov 14, 2024

OBE by #1544

@Gold856 Gold856 closed this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcm001 mcm001 mcm001 requested changes

@spacey-sooty spacey-sooty spacey-sooty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gold856 @mcm001 @spacey-sooty