Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically detect and report hardware model for most SBCs #1540

Merged

Conversation

stephenjust
Copy link
Contributor

ARM-based machines populate the device model into Device Tree. We can use this information to automatically detect and report the hardware model for most Single Board Computers (SBCs). Vendors who want to override this can still do so via the value in the configuration database.

@stephenjust stephenjust requested a review from a team as a code owner November 9, 2024 21:44
@stephenjust
Copy link
Contributor Author

image

@mcm001
Copy link
Contributor

mcm001 commented Nov 9, 2024

Another thing to note: new for 2025, our provided images have the git sha provided in /opt/photonvision/image-version. See https://github.com/PhotonVision/photon-image-modifier/pull/33/files#diff-7829468e86c1cc5d5133195b5cb48e1ff6c75e3e9203777f6b2e379d9e4882b3

@mcm001
Copy link
Contributor

mcm001 commented Nov 10, 2024

Works on my linux x64 install at least. Would be great to see testing on Pi and Orange Pi too

@crschardt
Copy link
Contributor

image

It works on my OrangePi too. I say send it.

Copy link
Contributor

@crschardt crschardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crschardt crschardt merged commit b5d48a6 into PhotonVision:master Nov 10, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants