-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add python simulation #1532
Add python simulation #1532
Conversation
Yall are absolutely insane for crunching through 1500 lines of language translation, love it. I was attempting to go the robotpy bindings route to side-step needing to re-implement photon sim in Python but hit build system roadblocks. If this works this'll be pretty awesome to see upstreamed. |
9e8ebc8
to
e2c7510
Compare
@mcm001 @spacey-sooty I think you're the right ones to ping here... Some of this can and probably should be split out if you want.
Do you want these things prepped and sent in outside this PR? In other news, we are driving around in our sim with simulated vision and results returning to our code. There is still more to go, but it is very close! |
Im prolly not the right person to ask but having these as seperate PRs would make this more reviewable so would probably be good. Thanks for the incredible work, you'll have to show me at SCR |
Yeah let's split out the Packet autogen and spelling changes into their own PR for reviewability |
b818ff2
to
9f7492d
Compare
done |
fd28c1d
to
8080073
Compare
Well this is as ready to go as it can be. We have ported all the things we and probably most teams will need, including the test harness. What do you want done about the lint job? #1545 broke things and I don't know how to fix it. I have tried going to both the same and a newer version of |
The "wpiformat" workflow uploads a patch file you can apply with |
Oh or apparently I don't have permission to do that. Apply this patch file: https://github.com/PhotonVision/photonvision/actions/runs/11765371019/artifacts/2168245903 |
Needs TimeInterpolatablePose3dBuffer
c098f23
to
c739fe5
Compare
Woot! Is anything else needed from us for the time being @mcm001? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of these days, CI will be green and yet the code is broken. But it is not this day
@mcm001 I know you made a release a few hours ago, but would you be willing to make another one with the sim stuff, or is there a cycle time we have to wait on? I want to make life easier for the kids on my team so they don't have to install dev builds if possible |
Do we publish dev builds of photonlib to pypi? If not yeah I'm open to a quirk patch. When is your need by date? |
Yee we have got tags automated -- looks like we don't push artifacts for every commit to main like Java and C++ though. I'll drop a tag once the dust settles a bit more. |
We are doing the whole native python thing. We think we are most of the way through since we can run it with our robot code in sim but no data is coming through just yet. Hopefully if anyone else has other progressive we can share.