Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Only add maturity/suffix to version if groups matched #1146

Merged
merged 5 commits into from
Jan 11, 2024

Conversation

mcm001
Copy link
Contributor

@mcm001 mcm001 commented Jan 10, 2024

No description provided.

@mcm001 mcm001 requested a review from a team as a code owner January 10, 2024 14:00
@gerth2
Copy link
Contributor

gerth2 commented Jan 11, 2024

Looks solid to me. Copied the logic into another file and ran a few tests, I'm happy with the results:

PS C:\Users\chris\git\firstRoboPy> & C:/Users/chris/AppData/Local/Programs/Python/Python312/python.exe c:/Users/chris/git/firstRoboPy/testVersions.py
==============
Git Describe: v2024.1.1
using full release 2024.1.1
Building version 2024.1.1
==============
Git Describe: v2024.1.2
using full release 2024.1.2
Building version 2024.1.2
==============
Git Describe: v2024.1
Warning, no valid version found
Building version v2024.1
==============
Git Describe: v2024.1.2-beta-4.6
using beta group matcher
Building version v2024.1.2.beta.46
==============
Git Describe: asdfasdf
Warning, no valid version found
Building version asdfasdf

Copy link
Contributor

@gerth2 gerth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@gerth2 gerth2 merged commit 0cec1ee into PhotonVision:master Jan 11, 2024
17 of 18 checks passed
@mcm001 mcm001 deleted the 2023-01-10_pep_version branch January 11, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants