Fix maven directories for publishing #1139
Conversation
| @@ -7,7 +7,7 @@ apply plugin: "edu.wpi.first.NativeUtils" | |||
| import java.nio.file.Path | |||
|
|
|||
| ext { | |||
| nativeName = "photonlib" | |||
There was a problem hiding this comment.
These really should be lowercase, this would also cause the vendordep to break which we want to avoid. Is there a specific reason why this change resolves the issue?
There was a problem hiding this comment.
def baseArtifactId = nativeName
This line makes the artifact id based on the nativename. Thats why this fixes the maven dir issue
There was a problem hiding this comment.
Why would the vendor dep break?
There was a problem hiding this comment.
Because the vendordep is looking for that, previously it was Title case but now it is all lowercase, old vendor deps are looking for Title case, whereas all beta vendordeps are looking for lowercase. Going back would break all beta vendordeps.
|
Proposal: just change the artifact id of the json? |
|
Also keep in mind that windows is not case sensitive. If we change caps we should also change spelling |
Changes between years have only been in capitalization, not spelling, windows should be unaffected? I vote to just change the URL, especially if we are already fine with breaking the year to year, cause we did |
|
Let's change photonvision/photon-lib/build.gradle Line 102 in 0cec1ee |
|
Closing for now since it seems like we just stuck with the quietly breaking change |
This fixes the issue where new releases were going to a photonlib-* directory instead of PhotonLib-*