Create photon-core JNI #1067
Create photon-core JNI #1067
Conversation
|
I would create a new jni section in shared and apply that to photon-server and photon-core instead of modifying javacpp. photon-targeting and photon-lib aren't currently JNI'd unless that is something we are trying to add. |
|
I'm still not sure how to make the Java side of photon core/server depend on native artifacts we build anyways |
|
What components do we want in photon-core JNI? I thought we wanted to keep LibCamera and MrCal as separate repos. Do we want to merge those dependencies into core's cpp system then replace their discrete JNIs with a custom one. An issue is there is a lot of platform-specific stuff going on which would make build system annoying with linking dependencies properly. If we want to do it that way, we would create calibration JNIs in cpp that abstract out either OpenCV and MrCal implements and then the gradle build arguments would decide which system is linked. That way our Java code has 0 changes and our cpp code is build based. Because OpenCV is universally supported, we can still provide overrides as a setting which would be no-ops for MrCal if that platform wasn't supported. BTW, I've only ever done this on cmake, not gradle. gradle bad tbh. |
No description provided.