Fix Logger - ConfigManager circular reference #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crschardt
changed the title
crschardt
force-pushed
the
fix-Logger-ConfigManager-circular-reference
branch
from
e81d5c6
to
5dc3a47
Compare
|
Any idea why this failed on the fat Jar - Linux? It passed all the tests before master was merged. |
|
Looks good now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a circular import between ConfigManager and Logger that was preventing some messages from being logged as PV was starting. Logger calls ConfigManager on initialization to get the path for the log file, but ConfigManager also creates and instance of Logger. Somehow, this all gets resolved, but it means that some of the log messages from SqlConfigProvider disappear.
The fix presented here is by creating a new class, PathManager, that Logger and ConfigManager both access to get the directory paths they need. Right now I've made the minimum changes to break the dependency. If this is the right way to go forward, we should move all the path-related methods from ConfigManager into PathManager so that there is a clean separation.