Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Protobuf] Make MultiTarget result optional #1024

Open
wants to merge 99 commits into
base: master
Choose a base branch
from
Open

[Protobuf] Make MultiTarget result optional #1024

wants to merge 99 commits into from

Conversation

srimanachanta
Copy link
Member

@srimanachanta srimanachanta commented Nov 24, 2023 •
edited
Loading

Passing an isPresent prop in the PNPResult doesn't make much sense instead of just passing an Optional<PNPResult>.

Based on #974 because I am too lazy to reimplement Packet

Also combines the ProtobufMultitargetResult and PNPResult messages and makes ProtobufMultitargetResult optional on ProtoufPipelineResult. This should reduce total serialization byte size as less messages need to be packed and optional saves time.

mcm001 and others added 30 commits October 20, 2023 18:57
@mcm001
Bump to beta 2
c95feb2
@mcm001
Reduce copy paste spam going forwards
397d28d
@mcm001
Bump gradle
2d5ccd6
@mcm001
Maybe sorta half working
acaefba
@srimanachanta
Merge branch 'master' into 2023-10-20_protobuf
0392f50
@mcm001
Remove optional
a5f69e1
@mcm001
bump wpilib
20d7580
@srimanachanta
Merge branch 'master' into 2023-10-20_protobuf
ebadcb7
@srimanachanta
Merge branch 'master' into 2023-10-20_protobuf
a6bd9f8
@mcm001
Merge remote-tracking branch 'upstream/master' into 2023-10-20_protobuf
95a0384
@srimanachanta
Change targeting classes
aebcfa0
@srimanachanta
Update OpenCVHelp.java
5345b1b
@srimanachanta
Merge branch '2023-10-20_protobuf' of https://github.com/mcm001/photo…
ce248c0 
…nvision into pr/974
@srimanachanta
Merge branch 'master' into 2023-10-20_protobuf
29e2df1
@srimanachanta
Update build.gradle
42f1c4b
@srimanachanta
fix licence
fd920fd
@srimanachanta
keep cleaning up
bfb84d4
@srimanachanta
more formatting fixes
030f543
@srimanachanta
Update NTDataPublisher.java
381e756
@srimanachanta
Basic Protobuf Implementation
c362730
@srimanachanta
Update SimPhotonCamera.java
6f5b242
@srimanachanta
rename rawBytesEntry -> pipelineResults pub/sub
db6ad10
@srimanachanta
handle crap
6d5759c
@srimanachanta
Formatting fixes
fafe163
@srimanachanta
Add protobuf tests
d9c32de
@srimanachanta
Fix bugs with packing and unpacking
7246a81
@srimanachanta
Formatting fixes
5d100ce
@srimanachanta
prob wont fix but one can hope
2043802
@srimanachanta
add equality tests
6b9f0c9
@srimanachanta
fix assertion test
4a5f145
srimanachanta and others added 22 commits November 21, 2023 15:01
@srimanachanta
fix PNPResult encoding bug
b911394
@srimanachanta
bump wpilib again
a6b669e
@srimanachanta
fix gradle
1a21927
@srimanachanta
look
5d931ff
@srimanachanta
Merge branch 'master' into 2023-10-20_protobuf
558c1b4
@srimanachanta
remove modified files
0ab58a7
@srimanachanta
Merge branch '2023-10-20_protobuf' of https://github.com/mcm001/photo…
3de2b6c 
…nvision into pr/974
@mcm001
Manually initialize pnpresult
8ece13b
@mcm001
Bump wpilib version in examples
d12eca5
@mcm001
Merge remote-tracking branch 'upstream/master' into 2023-10-20_protobuf
d18e3d1
@mcm001
Update javacommon.gradle
9340e4f
@mcm001
Update build.gradle
1504f59
@mcm001
Update build.gradle
f98ed57
@srimanachanta
Merge branch 'master' into 2023-10-20_protobuf
7e322e9
@srimanachanta
bump wpilib
98e0117
@srimanachanta
Merge branch '2023-10-20_protobuf' of https://github.com/mcm001/photo…
a4d7617 
…nvision into pr/974
@mcm001
Update build.gradle
cadbb09
@srimanachanta
make multitarget optional java
4456acc
@srimanachanta
update java tests
0f0727c
@srimanachanta
Update cpp
ca15e66
@srimanachanta
update tests
4826b18
@srimanachanta
Formatting fixes
7123f30
@srimanachanta srimanachanta requested a review from a team as a code owner November 24, 2023 20:34
@srimanachanta
Copy link
Member Author

Optional Multitarget Protobuf:

Name Size (Bytes)
DriverMode 9 Bytes
Reflective (1 Target) 290 Bytes
AprilTag Normal (4 tags) 1417 Bytes
AprilTag Multitag (4 tags) 1597 Bytes
AprilTag Multitag (4 tags) + Always do SingleTag 1597 Bytes
Aruco Normal (4 tags) 1417 Bytes
Aruco Multitag (4 tags) 1597 Bytes
Aruco Multitag (4 tags) + Always do SingleTag 1597 Bytes

@srimanachanta srimanachanta mentioned this pull request Dec 19, 2023
Open
@srimanachanta srimanachanta changed the title Make MultiTarget result optional [Protobuf] Make MultiTarget result optional Dec 19, 2023
@mcm001
Copy link
Contributor

mcm001 commented Oct 13, 2024

needs to be rebased or is this good to close?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srimanachanta @mcm001