[build] Gradle Cleanup #1021
Merged
[build] Gradle Cleanup #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcm001
reviewed
Nov 22, 2023
| def versionFileIn = file("${rootDir}/shared/PhotonVersion.java.in") | ||
| writePhotonVersionFile(versionFileIn, Path.of("$projectDir", "src", "main", "java", "org", "photonvision", "PhotonVersion.java"), | ||
| versionString) | ||
| } | ||
|
|
||
| build.dependsOn writeCurrentVersionJava | ||
| build.dependsOn writeCurrentVersion |
There was a problem hiding this comment.
What's wrong with the old name?
There was a problem hiding this comment.
Just matched photon-lib now
| @@ -5,6 +5,26 @@ apply plugin: 'edu.wpi.first.NativeUtils' | |||
| apply from: "${rootDir}/shared/config.gradle" | |||
| apply from: "${rootDir}/shared/javacommon.gradle" | |||
|
|
|||
| wpilibTools.deps.wpilibVersion = wpi.versions.wpilibVersion.get() | |||
|
|
|||
| def nativeConfigName = 'wpilibNatives' | |||
There was a problem hiding this comment.
It's ok if multiple projects share this name right?
There was a problem hiding this comment.
And it runs in test mode and the shadow jar and robot sim and everything? This could cause unsatisfied link errors if you aren't careful
There was a problem hiding this comment.
Test mode worked, I didn't run the simulation. Also if you look at main, they are both named the exact same thing so I'm fairly sure this doesn't matter.
srimanachanta
force-pushed
the
build-system-cleanup
branch
from
d266104
to
4563d61
Compare
mcm001
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup project-wide gradle configuration.