fix bad implementation of global variables and version check, which p…

…revented python version checks from working (#1050)
PhotonVision · Dec 17, 2023 · f7f304c · f7f304c
1 parent 82b82fe
commit f7f304c
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/photon-lib/py/photonlibpy/photonCamera.py b/photon-lib/py/photonlibpy/photonCamera.py
@@ -19,6 +19,7 @@ class VisionLEDMode(Enum):
 
 
 def setVersionCheckEnabled(enabled: bool):
+    global _VERSION_CHECK_ENABLED
     _VERSION_CHECK_ENABLED = enabled
 
 
@@ -131,12 +132,16 @@ def isConnected(self) -> bool:
         return (now - self.prevHeartbeatChangeTime) < 0.5
 
     def _versionCheck(self) -> None:
+        global lastVersionTimeCheck
+
         if not _VERSION_CHECK_ENABLED:
             return
 
         if (Timer.getFPGATimestamp() - lastVersionTimeCheck) < 5.0:
             return
 
+        lastVersionTimeCheck = Timer.getFPGATimestamp()
+
         if not self.heartbeatEntry.exists():
             cameraNames = (
                 self.cameraTable.getInstance().getTable(self._tableName).getSubTables()