Skip to content

Commit

Permalink
revert to targetSdkVersion 31 to avoid issues with notifications not …
Browse files Browse the repository at this point in the history 
…showing
  • Loading branch information
@PhilippC
PhilippC committed Feb 1, 2023
1 parent c86f9b3 commit 9958a73
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions src/keepass2android/Properties/AndroidManifest_net.xml
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
android:versionCode="188"
android:versionName="1.09e-r0"
android:versionCode="189"
android:versionName="1.09e-r1"
package="keepass2android.keepass2android"
xmlns:tools="http://schemas.android.com/tools"
android:installLocation="auto">
Expand Down Expand Up @@ -43,7 +43,7 @@
</intent>
</queries>

<uses-sdk android:minSdkVersion="21" android:targetSdkVersion="33" />
<uses-sdk android:minSdkVersion="21" android:targetSdkVersion="31" />
<permission android:description="@string/permission_desc2" android:icon="@drawable/ic_launcher" android:label="KP2A entry search" android:name="keepass2android.keepass2android.permission.KP2aInternalSearch" android:protectionLevel="signature" />
<permission android:description="@string/permission_desc3" android:icon="@drawable/ic_launcher" android:label="KP2A choose autofill dataset" android:name="keepass2android.keepass2android.permission.Kp2aChooseAutofill" android:protectionLevel="signature" />

Expand Down
6 changes: 3 additions & 3 deletions src/keepass2android/Properties/AndroidManifest_nonet.xml
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
android:versionCode="187"
android:versionName="1.09e-r0"
android:versionCode="189"
android:versionName="1.09e-r1"
package="keepass2android.keepass2android_nonet"
xmlns:tools="http://schemas.android.com/tools"
android:installLocation="auto">
Expand Down Expand Up @@ -40,7 +40,7 @@
</intent>
</queries>

<uses-sdk android:minSdkVersion="18" android:targetSdkVersion="33" />
<uses-sdk android:minSdkVersion="18" android:targetSdkVersion="31" />
<permission android:description="@string/permission_desc2" android:icon="@drawable/ic_launcher_offline" android:label="KP2A entry search" android:name="keepass2android.keepass2android_nonet.permission.KP2aInternalSearch" android:protectionLevel="signature" />
<permission android:description="@string/permission_desc3" android:icon="@drawable/ic_launcher_offline" android:label="KP2A choose autofill dataset" android:name="keepass2android.keepass2android_nonet.permission.Kp2aChooseAutofill" android:protectionLevel="signature" />
<application
Expand Down

3 comments on commit 9958a73

@tenzap
Copy link
Contributor

@tenzap tenzap commented on 9958a73 Feb 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are back to target 31, linux job in github Workflow should work again

@tenzap
Copy link
Contributor

@tenzap tenzap commented on 9958a73 Feb 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realised you didn't change targetframework in the csproj. It is unlikely Linux job will work in that case. You can discard my previous comment

@PhilippC
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I consider this only a temporary workaround, Google Play will force to update to 33 later this year, but I didn't have time to implement the permission request workflow nicely and need to publish the 31 version asap as it already has restricted visibility on Play now :-(

Please sign in to comment.