Fixed issue where Projectile would spawn at world orgin instead of bullet_point in Godot 4.3 #285
Conversation
I'm using Godot 4.3, for some reason (I don't know why), the projectile would spawn at the world origin instead of the bullet_point on the player. These two lines of code set the transform and rotation to the bullet point fixing the issue.
Forgot Comment on line 41.
|
Hey, thanks for this! Will take a look but looks like this should be 4.2 compatible. Would be curios if there are any issues you ran into (besides this one 😅 ) |
|
Oh yeah... I'm running into issues... this and one other big one that has to do with the way the guns display, it mostly just works, but I'll detail them over there as best I can. I didn't even mean to upgrade to 4.3, I'm just new and using Godot and thought "Yeah, it's fine, I'll just use the Arch repo what could go wrong?" and here I am trying to upgrade your repo to work with 4.3, lol... ...I've learned over the years having been on Linux for so long now, it's best to not complain and just fix everything yourself if you can until you're 100% sure you're totally lost. So I didn't wanna file any bug reports until I fixed them like this one. |
|
@JohnnyThunder2 I've commented out one line. For me this one caused the projectiles to be spawned facing sideways / wrong direction. Let me know if this changes the behavior much on your end. If not, I'm happy to merge this in. |
|
OK, I have some weird bug. If I comment that line of code out and shoot along the Z axis, the bullet shoots straight, if I turn and shoot along the X-axis the bullet shoots sideways. I added that line of code and it seems to work correctly for me... I'm wondering if this is a Godot bug between the Linux and windows build? Need to investigate more. Edit: You know, I doubt that's the case... I'm probably just doing something wrong... need to study more. |
|
Yup, yup... I'm a total noob. I rotated the bullet_point 90 degrees in the y axis and forgot I had done so... Thank goodness, I was just about to dive deep into trying to use Grep to figure out where the global_transform.basis method were in the source code of Godot... lol... OK... will try and figure it out when I can. |
Hi... first Pull Request ever, figured I would just fix the issue before I brought it up.
I'm on Arch Linux running Godot 4.3, so possibly this is just an issue I'm having but, for some reason the Toy Pistol wieldable would only spawn projectiles at the world origin instead of the bullet_point origin of the player. After adding these two lines of code (Sorry if they are a mess, I'm a novice programmer) it fixed the issue and the Toy Pistol now works as it should.
Line 46 doesn't really do anything, but while I was troubleshooting, I insured the default value was set correctly. Don't believe that line needs to be added.