Simplify the Jacobian visitors. NFC

PetroZarytskyi · Jun 11, 2024 · 340ad91 · 340ad91
1 parent 6efcd08
commit 340ad91
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 94 deletions.
diff --git a/include/clad/Differentiator/JacobianModeVisitor.h b/include/clad/Differentiator/JacobianModeVisitor.h
diff --git a/lib/Differentiator/CMakeLists.txt b/lib/Differentiator/CMakeLists.txt
@@ -31,7 +31,6 @@ llvm_add_library(cladDifferentiator
   ErrorEstimator.cpp
   EstimationModel.cpp
   HessianModeVisitor.cpp
-  JacobianModeVisitor.cpp
   MultiplexExternalRMVSource.cpp
   PushForwardModeVisitor.cpp
   ReverseModeForwPassVisitor.cpp

diff --git a/lib/Differentiator/DerivativeBuilder.cpp b/lib/Differentiator/DerivativeBuilder.cpp
@@ -19,7 +19,6 @@
 #include "clad/Differentiator/DiffPlanner.h"
 #include "clad/Differentiator/ErrorEstimator.h"
 #include "clad/Differentiator/HessianModeVisitor.h"
-#include "clad/Differentiator/JacobianModeVisitor.h"
 #include "clad/Differentiator/PushForwardModeVisitor.h"
 #include "clad/Differentiator/ReverseModeForwPassVisitor.h"
 #include "clad/Differentiator/ReverseModeVisitor.h"
@@ -371,8 +370,8 @@ static void registerDerivative(FunctionDecl* derivedFD, Sema& semaRef) {
       HessianModeVisitor H(*this);
       result = H.Derive(FD, request);
     } else if (request.Mode == DiffMode::jacobian) {
-      JacobianModeVisitor J(*this);
-      result = J.Derive(FD, request);
+      ReverseModeVisitor R(*this);
+      result = R.Derive(FD, request);
     } else if (request.Mode == DiffMode::error_estimation) {
       ReverseModeVisitor R(*this);
       InitErrorEstimation(m_ErrorEstHandler, m_EstModel, *this);

diff --git a/lib/Differentiator/JacobianModeVisitor.cpp b/lib/Differentiator/JacobianModeVisitor.cpp