Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eng 1221 ps80 add triggers for ps81 minitests and package tests #2372

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

panchal-yash
Copy link
Contributor

No description provided.

Add git diff check for package-testing VERSION file modification for error free re-run of the build job during VERSION file commit (Similar to PXB80 setup)
@panchal-yash panchal-yash force-pushed the ENG-1221-ps80-add-triggers-for-ps81-minitests-and-package-tests branch from d6ae827 to 77c5aba Compare November 17, 2023 03:43
Comment on lines +125 to +137
if ("${PS8_RELEASE_VERSION}") { // Checks if PS8_RELEASE_VERSION is not empty
echo "MAJOR VERSION IS ${PS8_RELEASE_VERSION}"

if("${PS8_RELEASE_VERSION}" == "8.0"){
ps80_install_pkg_minitests_playbook = 'ps_80.yml'
PS8_RELEASE_VERSION_PRODUCT_TO_TEST = 'ps80'
}
else if("${PS8_RELEASE_VERSION}" == "8.1" ){
ps80_install_pkg_minitests_playbook = 'ps_81.yml'
PS8_RELEASE_VERSION_PRODUCT_TO_TEST = 'ps81'
}
}
else{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So on each new release you are going to add additional if-block?
maybe we should reuse value from PS8_RELEASE_VERSION variable?

Comment on lines +791 to +800
if [[ "${PS8_RELEASE_VERSION}" == "8.0" ]]; then
OLD_REV=\$(cat VERSIONS | grep PS80_REV | cut -d '=' -f2- )
OLD_VER=\$(cat VERSIONS | grep PS80_VER | cut -d '=' -f2- )
sed -i s/PS80_REV=\$OLD_REV/PS80_REV='"'${REVISION}'"'/g VERSIONS
sed -i s/PS80_VER=\$OLD_VER/PS80_VER='"'${PS_RELEASE}'"'/g VERSIONS
elif [[ "${PS8_RELEASE_VERSION}" == "8.1" ]];then
OLD_REV=\$(cat VERSIONS | grep PS81_REV | cut -d '=' -f2- )
OLD_VER=\$(cat VERSIONS | grep PS81_VER | cut -d '=' -f2- )
sed -i s/PS81_REV=\$OLD_REV/PS81_REV='"'${REVISION}'"'/g VERSIONS
sed -i s/PS81_VER=\$OLD_VER/PS81_VER='"'${PS_RELEASE}'"'/g VERSIONS
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same. one more block on each release. It is better to unify it.

else
echo "There are changes"
git add -A
git commit -m "Autocommit: add ${REVISION} and ${PS_RELEASE} for ps80 ${PS8_RELEASE_VERSION} package testing VERSIONS file."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation

Comment on lines +818 to +820
if("${mini_test_error}" == "True"){
echo "NOT TRIGGERING PACKAGE TESTS AND INTEGRATION TESTS DUE TO MINITEST FAILURE !!"
}else{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need this block?
just compare with False

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants