Example data fits Sphinx Gallery's image dimensions #1246
Conversation
|
👋 Hey, looks like you've updated some demos! 🐘 Don't forget to update the Please hide this comment once the field(s) are updated. Thanks! |
doctorperceptron
changed the title
|
Thank you for opening this pull request. You can find the built site at this link. Deployment Info:
Note: It may take several minutes for updates to this pull request to be reflected on the deployed site. |
doctorperceptron
requested review from
ikurecic,
justinpickering and
DanielNino27
There was a problem hiding this comment.
Thanks @doctorperceptron ! Just one small question. If the settings on sphix negate specifying figsize than your fix looks good to me.
| for i in range(5): | ||
| axes[i].matshow(X_train[2*i]) | ||
| axes[i].axis('off') | ||
| fig, axes = plt.subplots(nrows=2, ncols=3, layout="constrained") |
There was a problem hiding this comment.
Would specifyingfigsizeinside of subplots help or would that be superseded by the display settings in sphinx? It looks better but seems disproportionately big
There was a problem hiding this comment.
It might! Let's find out...
There was a problem hiding this comment.
Hmm small problem, because we use matplotlib inline the figure gets cropped by Jupyter and makes the actual size unpredictable. I think this is the best we can do without disabling matplotlib inline (currently set globally for all demos).
https://matplotlib.org/stable/gallery/subplots_axes_and_figures/figure_size_units.html#id1
There was a problem hiding this comment.
Ok - thanks for checking it out. In that case, the fix is fine with me.
There was a problem hiding this comment.
LGTM!
Just a note, this new figure layout introduces a 6th figure. Not sure if that's an issue or not given the context of this demo. cc @ikurecic
These figures are a representative sample of the data. Afaik the initial choice of 5 was arbitrary, so changing it to 6 shouldn't material affect the demo. |
Title:
Adapt example data in demo to fit Sphinx Gallery's image dimensions
Summary:
Sphinx Gallery renders single images at 640px by 480px. Adjusting the layout of the example data to better fit these dimensions and reduce white space.
Relevant references:
https://app.shortcut.com/xanaduai/story/76532
Before:
After: